commit 3ddc4ac96e276a58fc02328a61bfbda9e8406bec
author Yahan Zhou <yahan@google.com> Tue May 23 22:39:06 2023 +0000
committer Copybara-Service <copybara-worker@google.com> Tue May 23 15:40:00 2023 -0700
tree 5301c000077620cfffb16c2374bcace0b1790b36
parent 17208644b1295c0046573d2b8fc7487fd9266d84

Merge "Rebind context more frequently when posting on main thread"

GitOrigin-RevId: 194f04a5c1131c828442385d39d56460db428b08
Change-Id: I384a4b13aa34cd4cd9f1ec97da2304abb146a036

host/PostWorker.h

diff --git a/host/PostWorker.h b/host/PostWorker.h
index 13c2ec5..1cfe105 100644
--- a/host/PostWorker.h
+++ b/host/PostWorker.h
@@ -83,14 +83,14 @@
     FrameBuffer* mFb;
     Compositor* m_compositor = nullptr;
 
-   private:
+   protected:
     // If m_mainThreadPostingOnly is true, schedule the task to UI thread by
     // using m_runOnUiThread. Otherwise, execute the task on the current thread.
+    bool m_mainThreadPostingOnly = false;
 
    private:
     using UiThreadRunner = std::function<void(UiUpdateFunc, void*, bool)>;
 
-    bool m_mainThreadPostingOnly = false;
     UiThreadRunner m_runOnUiThread = 0;
 
     std::unordered_map<uint32_t, std::shared_future<void>> m_composeTargetToComposeFuture;

host/PostWorkerGl.cpp

diff --git a/host/PostWorkerGl.cpp b/host/PostWorkerGl.cpp
index 815fbee..8eb27da 100644
--- a/host/PostWorkerGl.cpp
+++ b/host/PostWorkerGl.cpp
@@ -64,8 +64,10 @@
 }
 
 std::shared_future<void> PostWorkerGl::postImpl(ColorBuffer* cb) {
-    if (!mContextBound) {
+    if (!mContextBound || m_mainThreadPostingOnly) {
         // This might happen on headless mode
+        // Also if posting on main thread, the context binding can get polluted easily, which
+        // requires frequent rebinds.
         setupContext();
     }
     std::shared_future<void> completedFuture = std::async(std::launch::deferred, [] {}).share();
@@ -246,7 +248,7 @@
 // displaying whatever happens to be in the back buffer,
 // clear() is useful for outputting consistent colors.
 void PostWorkerGl::clearImpl() {
-    if (!mContextBound) {
+    if (!mContextBound || m_mainThreadPostingOnly) {
         // This might happen on headless mode
         setupContext();
     }
@@ -254,7 +256,7 @@
 }
 
 std::shared_future<void> PostWorkerGl::composeImpl(const FlatComposeRequest& composeRequest) {
-    if (!mContextBound) {
+    if (!mContextBound || m_mainThreadPostingOnly) {
         // This might happen on headless mode
         setupContext();
     }