commit d280758a2a6b29acfdaa9a27eeb6f5735395314a
author Lingfeng Yang <lfy@google.com> Tue Apr 27 16:06:35 2021 -0700
committer Lingfeng Yang <lfy@google.com> Tue Apr 27 18:57:41 2021 -0700
tree 002ec39811410c5d82d3ed1e28cc3f15d8d00b51
parent a5c170586b3e6c645b9394bf28cfaf9af093e661

Use GLint from client state parameters in glGetBooleanv

Bug: 186021150

Some values (like gl stencil ones) might end with zero bits making the cast to boolean count as
zero.

Test: dEQP-GLES3.functional.state_query* regressions fixed
Change-Id: Iaab1dc8af0f3965fa39421de14b906d62bb5fcc7

system/GLESv2_enc/GL2Encoder.cpp

diff --git a/system/GLESv2_enc/GL2Encoder.cpp b/system/GLESv2_enc/GL2Encoder.cpp
index 931fa4e..add8425 100755
--- a/system/GLESv2_enc/GL2Encoder.cpp
+++ b/system/GLESv2_enc/GL2Encoder.cpp
@@ -1104,10 +1104,14 @@
 
     default:
         if (!state) return;
-        if (!state->getClientStateParameter<GLboolean>(param, ptr)) {
-            ctx->safe_glGetBooleanv(param, ptr);
+        {
+            GLint intVal;
+            if (!state->getClientStateParameter<GLint>(param, &intVal)) {
+                ctx->safe_glGetBooleanv(param, ptr);
+            } else {
+                *ptr = (intVal != 0) ? GL_TRUE : GL_FALSE;
+            }
         }
-        *ptr = (*ptr != 0) ? GL_TRUE : GL_FALSE;
         break;
     }
 }