Google Git
Sign in
fuchsia / third_party / Vulkan-ValidationLayers / HEAD / . / layers / stateless / sl_pipeline.cpp
blob: a92eb871a474490300e34d9454ba4411b97cd8be [file] [log] [blame]
/* Copyright (c) 2015-2023 The Khronos Group Inc.
* Copyright (c) 2015-2023 Valve Corporation
* Copyright (c) 2015-2023 LunarG, Inc.
* Copyright (C) 2015-2023 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "stateless/stateless_validation.h"
#include "generated/enum_flag_bits.h"
bool StatelessValidation::manual_PreCallValidateCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo,
const VkAllocationCallbacks *pAllocator,
VkPipelineLayout *pPipelineLayout,
const ErrorObject &error_obj) const {
bool skip = false;
const Location create_info_loc = error_obj.location.dot(Field::pCreateInfo);
// Validate layout count against device physical limit
if (pCreateInfo->setLayoutCount > device_limits.maxBoundDescriptorSets) {
skip |= LogError("VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286", device, create_info_loc.dot(Field::setLayoutCount),
"(%" PRIu32 ") exceeds physical device maxBoundDescriptorSets limit (%" PRIu32 ").",
pCreateInfo->setLayoutCount, device_limits.maxBoundDescriptorSets);
}
if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library)) {
for (uint32_t i = 0; i < pCreateInfo->setLayoutCount; ++i) {
if (!pCreateInfo->pSetLayouts[i]) {
// TODO - Combine with other check in CoreChecks
skip |= LogError("VUID-VkPipelineLayoutCreateInfo-graphicsPipelineLibrary-06753", device,
create_info_loc.dot(Field::pSetLayouts, i),
"is VK_NULL_HANDLE, but VK_EXT_graphics_pipeline_library is not enabled.");
}
}
}
// Validate Push Constant ranges
for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
const Location pc_loc = create_info_loc.dot(Field::pPushConstantRanges, i);
const uint32_t offset = pCreateInfo->pPushConstantRanges[i].offset;
const uint32_t size = pCreateInfo->pPushConstantRanges[i].size;
const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
// Check that offset + size don't exceed the max.
// Prevent arithetic overflow here by avoiding addition and testing in this order.
if (offset >= max_push_constants_size) {
skip |= LogError("VUID-VkPushConstantRange-offset-00294", device, pc_loc.dot(Field::offset),
"(%" PRIu32
") that exceeds this "
"device's maxPushConstantSize of %" PRIu32 ".",
offset, max_push_constants_size);
}
if (size > max_push_constants_size - offset) {
skip |= LogError("VUID-VkPushConstantRange-size-00298", device, pc_loc.dot(Field::offset),
"(%" PRIu32 ") and size (%" PRIu32
") "
"together exceeds this device's maxPushConstantSize of %" PRIu32 ".",
offset, size, max_push_constants_size);
}
// size needs to be non-zero and a multiple of 4.
if (size == 0) {
skip |= LogError("VUID-VkPushConstantRange-size-00296", device, pc_loc.dot(Field::size),
"(%" PRIu32 ") is not greater than zero.", size);
}
if (size & 0x3) {
skip |= LogError("VUID-VkPushConstantRange-size-00297", device, pc_loc.dot(Field::size),
"(%" PRIu32 ") is not a multiple of 4.", size);
}
// offset needs to be a multiple of 4.
if ((offset & 0x3) != 0) {
skip |= LogError("VUID-VkPushConstantRange-offset-00295", device, pc_loc.dot(Field::offset),
"(%" PRIu32 ") is not a multiple of 4.", offset);
}
}
// As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
for (uint32_t j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
skip |= LogError("VUID-VkPipelineLayoutCreateInfo-pPushConstantRanges-00292", device, create_info_loc,
"pPushConstantRanges[%" PRIu32 "].stageFlags and pPushConstantRanges[%" PRIu32
"].stageFlags are both (%s).",
i, j, string_VkShaderStageFlags(pCreateInfo->pPushConstantRanges[i].stageFlags).c_str());
break; // Only need to report the first range mismatch
}
}
}
return skip;
}
bool StatelessValidation::ValidatePipelineShaderStageCreateInfo(const VkPipelineShaderStageCreateInfo *pCreateInfo,
const Location &loc) const {
bool skip = false;
const auto *required_subgroup_size_features =
vku::FindStructInPNextChain<VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT>(pCreateInfo->pNext);
if (required_subgroup_size_features) {
if ((pCreateInfo->flags & VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT) != 0) {
skip |= LogError("VUID-VkPipelineShaderStageCreateInfo-pNext-02754", device, loc.dot(Field::flags),
"(%s) includes VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT while "
"VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT is included in the pNext chain.",
string_VkPipelineShaderStageCreateFlags(pCreateInfo->flags).c_str());
}
}
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineTessellationStateCreateInfo(const VkPipelineTessellationStateCreateInfo &info,
uint32_t index, const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
constexpr std::array allowed_structs = {VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
skip |= ValidateStructPnext(loc, info.pNext, allowed_structs.size(), allowed_structs.data(), GeneratedVulkanHeaderVersion,
"VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
"VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
skip |=
ValidateReservedFlags(loc.dot(Field::flags), info.flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineVertexInputStateCreateInfo(const VkPipelineVertexInputStateCreateInfo &info,
uint32_t index, const Location &loc) const {
bool skip = false;
constexpr std::array allowed_structs = {VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
skip |= ValidateStructPnext(loc, info.pNext, allowed_structs.size(), allowed_structs.data(), GeneratedVulkanHeaderVersion,
"VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
"VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
skip |= ValidateArray(loc.dot(Field::vertexBindingDescriptionCount), loc.dot(Field::pVertexBindingDescriptions),
info.vertexBindingDescriptionCount, &info.pVertexBindingDescriptions, false, true, kVUIDUndefined,
"VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
skip |= ValidateArray(loc.dot(Field::vertexAttributeDescriptionCount), loc.dot(Field::pVertexAttributeDescriptions),
info.vertexAttributeDescriptionCount, &info.pVertexAttributeDescriptions, false, true, kVUIDUndefined,
"VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
if (info.pVertexBindingDescriptions != nullptr) {
for (uint32_t vertex_binding_description_index = 0; vertex_binding_description_index < info.vertexBindingDescriptionCount;
++vertex_binding_description_index) {
skip |= ValidateRangedEnum(
loc.dot(Field::pVertexBindingDescriptions, vertex_binding_description_index).dot(Field::inputRate),
"VkVertexInputRate", info.pVertexBindingDescriptions[vertex_binding_description_index].inputRate,
"VUID-VkVertexInputBindingDescription-inputRate-parameter");
}
}
if (info.pVertexAttributeDescriptions != nullptr) {
for (uint32_t vertex_attribute_description_index = 0;
vertex_attribute_description_index < info.vertexAttributeDescriptionCount; ++vertex_attribute_description_index) {
const VkFormat format = info.pVertexAttributeDescriptions[vertex_attribute_description_index].format;
skip |= ValidateRangedEnum(
loc.dot(Field::pVertexAttributeDescriptions, vertex_attribute_description_index).dot(Field::format), "VkFormat",
info.pVertexAttributeDescriptions[vertex_attribute_description_index].format,
"VUID-VkVertexInputAttributeDescription-format-parameter");
if (vkuFormatIsDepthOrStencil(format)) {
// Should never hopefully get here, but there are known driver advertising the wrong feature flags
// see https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/4849
skip |= LogError(device, kVUID_Core_invalidDepthStencilFormat,
"vkCreateGraphicsPipelines: "
"pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
"].format is a "
"depth/stencil format (%s) but depth/stencil formats do not have a defined sizes for "
"alignment, replace with a color format.",
index, vertex_attribute_description_index, string_VkFormat(format));
}
}
}
skip |= ValidateReservedFlags(loc.dot(Field::flags), info.flags, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask");
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineViewportStateCreateInfo(const VkPipelineViewportStateCreateInfo &info, uint32_t index,
const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineViewportStateCreateInfo-sType-sType");
constexpr std::array allowed_structs = {
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_DEPTH_CLIP_CONTROL_CREATE_INFO_EXT,
};
skip |= ValidateStructPnext(loc, info.pNext, allowed_structs.size(), allowed_structs.data(), GeneratedVulkanHeaderVersion,
"VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
"VUID-VkPipelineViewportStateCreateInfo-sType-unique");
skip |= ValidateReservedFlags(loc.dot(Field::flags), info.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineMultisampleStateCreateInfo(const VkPipelineMultisampleStateCreateInfo &info,
uint32_t index, const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineMultisampleStateCreateInfo-sType-sType");
constexpr std::array allowed_structs = {VK_STRUCTURE_TYPE_PIPELINE_COVERAGE_MODULATION_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_COVERAGE_REDUCTION_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_COVERAGE_TO_COLOR_STATE_CREATE_INFO_NV,
VK_STRUCTURE_TYPE_PIPELINE_SAMPLE_LOCATIONS_STATE_CREATE_INFO_EXT};
skip |= ValidateStructPnext(loc, info.pNext, allowed_structs.size(), allowed_structs.data(), GeneratedVulkanHeaderVersion,
"VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
"VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
skip |= ValidateReservedFlags(loc.dot(Field::flags), info.flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
skip |= ValidateBool32(loc.dot(Field::sampleShadingEnable), info.sampleShadingEnable);
skip |= ValidateArray(loc.dot(Field::rasterizationSamples), loc.dot(Field::pSampleMask), info.rasterizationSamples,
&info.pSampleMask, true, false, kVUIDUndefined,
"VUID-VkPipelineMultisampleStateCreateInfo-pSampleMask-parameter");
skip |= ValidateFlags(loc.dot(Field::rasterizationSamples), "VkSampleCountFlagBits", AllVkSampleCountFlagBits,
info.rasterizationSamples, kRequiredSingleBit,
"VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
skip |= ValidateBool32(loc.dot(Field::alphaToCoverageEnable), info.alphaToCoverageEnable);
skip |= ValidateBool32(loc.dot(Field::alphaToOneEnable), info.alphaToOneEnable);
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineColorBlendAttachmentState(const VkPipelineColorBlendAttachmentState &attachment_state,
uint32_t pipe_index, uint32_t attachment_index,
const Location &loc) const {
bool skip = false;
skip |= ValidateBool32(loc.dot(Field::blendEnable), attachment_state.blendEnable);
skip |= ValidateRangedEnum(loc.dot(Field::srcColorBlendFactor), "VkBlendFactor", attachment_state.srcColorBlendFactor,
"VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::dstColorBlendFactor), "VkBlendFactor", attachment_state.dstColorBlendFactor,
"VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::colorBlendOp), "VkBlendOp", attachment_state.colorBlendOp,
"VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::srcAlphaBlendFactor), "VkBlendFactor", attachment_state.srcAlphaBlendFactor,
"VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::dstAlphaBlendFactor), "VkBlendFactor", attachment_state.dstAlphaBlendFactor,
"VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::alphaBlendOp), "VkBlendOp", attachment_state.alphaBlendOp,
"VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
skip |= ValidateFlags(loc.dot(Field::colorWriteMask), "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
attachment_state.colorWriteMask, kOptionalFlags,
"VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineColorBlendStateCreateInfo(const VkPipelineColorBlendStateCreateInfo &info, uint32_t index,
const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
constexpr std::array allowed_structs = {VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT,
VK_STRUCTURE_TYPE_PIPELINE_COLOR_WRITE_CREATE_INFO_EXT};
skip |= ValidateStructPnext(loc, info.pNext, allowed_structs.size(), allowed_structs.data(), GeneratedVulkanHeaderVersion,
"VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
"VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
skip |=
ValidateFlags(loc.dot(Field::flags), "VkPipelineColorBlendStateCreateFlagBits", AllVkPipelineColorBlendStateCreateFlagBits,
info.flags, kOptionalFlags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-parameter");
skip |= ValidateBool32(loc.dot(Field::logicOpEnable), info.logicOpEnable);
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineDepthStencilStateCreateInfo(const VkPipelineDepthStencilStateCreateInfo &info,
uint32_t index, const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType");
skip |= ValidateStructPnext(loc, info.pNext, 0, nullptr, GeneratedVulkanHeaderVersion,
"VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
skip |= ValidateFlags(loc.dot(Field::flags), "VkPipelineDepthStencilStateCreateFlagBits",
AllVkPipelineDepthStencilStateCreateFlagBits, info.flags, kOptionalFlags,
"VUID-VkPipelineDepthStencilStateCreateInfo-flags-parameter");
skip |= ValidateBool32(loc.dot(Field::depthTestEnable), info.depthTestEnable);
skip |= ValidateBool32(loc.dot(Field::depthWriteEnable), info.depthWriteEnable);
skip |= ValidateRangedEnum(loc.dot(Field::depthCompareOp), "VkCompareOp", info.depthCompareOp,
"VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
skip |= ValidateBool32(loc.dot(Field::depthBoundsTestEnable), info.depthBoundsTestEnable);
skip |= ValidateBool32(loc.dot(Field::stencilTestEnable), info.stencilTestEnable);
skip |= ValidateRangedEnum(loc.dot(Field::front).dot(Field::failOp), "VkStencilOp", info.front.failOp,
"VUID-VkStencilOpState-failOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::front).dot(Field::passOp), "VkStencilOp", info.front.passOp,
"VUID-VkStencilOpState-passOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::front).dot(Field::depthFailOp), "VkStencilOp", info.front.depthFailOp,
"VUID-VkStencilOpState-depthFailOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::front).dot(Field::compareOp), "VkCompareOp", info.front.compareOp,
"VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::back).dot(Field::failOp), "VkStencilOp", info.back.failOp,
"VUID-VkStencilOpState-failOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::back).dot(Field::passOp), "VkStencilOp", info.back.passOp,
"VUID-VkStencilOpState-passOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::back).dot(Field::depthFailOp), "VkStencilOp", info.back.depthFailOp,
"VUID-VkStencilOpState-depthFailOp-parameter");
skip |= ValidateRangedEnum(loc.dot(Field::back).dot(Field::compareOp), "VkCompareOp", info.back.compareOp,
"VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
return skip;
}
// TODO Issue 4847 - Move logic to be autogenerated
bool StatelessValidation::ValidatePipelineInputAssemblyStateCreateInfo(const VkPipelineInputAssemblyStateCreateInfo &info,
uint32_t index, const Location &loc) const {
bool skip = false;
skip |= ValidateStructType(loc, "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO", &info,
VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
"VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
skip |= ValidateStructPnext(loc, info.pNext, 0, nullptr, GeneratedVulkanHeaderVersion,
"VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
skip |=
ValidateReservedFlags(loc.dot(Field::flags), info.flags, "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
skip |= ValidateRangedEnum(loc.dot(Field::topology), "VkPrimitiveTopology", info.topology,
"VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
skip |= ValidateBool32(loc.dot(Field::primitiveRestartEnable), info.primitiveRestartEnable);
return skip;
}
bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(
VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount, const VkGraphicsPipelineCreateInfo *pCreateInfos,
const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines, const ErrorObject &error_obj) const {
bool skip = false;
if (pCreateInfos != nullptr) {
for (uint32_t i = 0; i < createInfoCount; ++i) {
const Location create_info_loc = error_obj.location.dot(Field::pCreateInfos, i);
bool has_pre_raster_state = true;
// Create a copy of create_info and set non-included sub-state to null
auto create_info = pCreateInfos[i];
const auto *graphics_lib_info = vku::FindStructInPNextChain<VkGraphicsPipelineLibraryCreateInfoEXT>(create_info.pNext);
if (graphics_lib_info) {
if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_VERTEX_INPUT_INTERFACE_BIT_EXT)) {
create_info.pVertexInputState = nullptr;
create_info.pInputAssemblyState = nullptr;
}
if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT)) {
has_pre_raster_state = false;
create_info.pViewportState = nullptr;
create_info.pRasterizationState = nullptr;
create_info.pTessellationState = nullptr;
}
if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT)) {
create_info.pDepthStencilState = nullptr;
}
if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT)) {
create_info.pColorBlendState = nullptr;
}
if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
create_info.pMultisampleState = nullptr;
}
if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT))) {
create_info.layout = VK_NULL_HANDLE;
}
if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
create_info.renderPass = VK_NULL_HANDLE;
create_info.subpass = 0;
}
}
// Values needed from either dynamic rendering or the subpass description
uint32_t color_attachment_count = 0;
if (!create_info.renderPass) {
if (create_info.pColorBlendState && create_info.pMultisampleState) {
const auto rendering_struct = vku::FindStructInPNextChain<VkPipelineRenderingCreateInfo>(create_info.pNext);
// Pipeline has fragment output state
if (rendering_struct) {
color_attachment_count = rendering_struct->colorAttachmentCount;
if ((rendering_struct->depthAttachmentFormat != VK_FORMAT_UNDEFINED)) {
skip |= ValidateRangedEnum(
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::depthAttachmentFormat),
"VkFormat", rendering_struct->depthAttachmentFormat,
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06583");
if (!vkuFormatHasDepth(rendering_struct->depthAttachmentFormat)) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06587", device,
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::depthAttachmentFormat),
"(%s) does not have a depth aspect.", string_VkFormat(rendering_struct->depthAttachmentFormat));
}
}
if ((rendering_struct->stencilAttachmentFormat != VK_FORMAT_UNDEFINED)) {
skip |= ValidateRangedEnum(
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::stencilAttachmentFormat),
"VkFormat", rendering_struct->stencilAttachmentFormat,
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06584");
if (!vkuFormatHasStencil(rendering_struct->stencilAttachmentFormat)) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06588", device,
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::stencilAttachmentFormat),
"(%s) does not have a "
"stencil aspect.",
string_VkFormat(rendering_struct->stencilAttachmentFormat));
}
}
if (color_attachment_count != 0) {
skip |= ValidateRangedEnumArray(
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::colorAttachmentCount),
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::pColorAttachmentFormats),
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06579", "VkFormat", color_attachment_count,
rendering_struct->pColorAttachmentFormats, true, true);
}
if (rendering_struct->pColorAttachmentFormats) {
for (uint32_t j = 0; j < color_attachment_count; ++j) {
skip |= ValidateRangedEnum(
create_info_loc.pNext(Struct::VkPipelineRenderingCreateInfo, Field::pColorAttachmentFormats, j),
"VkFormat", rendering_struct->pColorAttachmentFormats[j],
"VUID-VkGraphicsPipelineCreateInfo-renderPass-06580");
}
}
}
// VkAttachmentSampleCountInfoAMD == VkAttachmentSampleCountInfoNV
auto attachment_sample_count_info = vku::FindStructInPNextChain<VkAttachmentSampleCountInfoAMD>(create_info.pNext);
if (attachment_sample_count_info && attachment_sample_count_info->pColorAttachmentSamples) {
color_attachment_count = attachment_sample_count_info->colorAttachmentCount;
for (uint32_t j = 0; j < color_attachment_count; ++j) {
skip |= ValidateFlags(
create_info_loc.pNext(Struct::VkAttachmentSampleCountInfoAMD, Field::pColorAttachmentSamples),
"VkSampleCountFlagBits", AllVkSampleCountFlagBits,
attachment_sample_count_info->pColorAttachmentSamples[j], kRequiredFlags,
"VUID-VkGraphicsPipelineCreateInfo-pColorAttachmentSamples-06592");
}
}
}
}
const VkPipelineCreateFlags flags = create_info.flags;
if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library)) {
if (create_info.stageCount == 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-stageCount-06604", device,
create_info_loc.dot(Field::stageCount), "is 0, but %s is not enabled",
VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME);
}
if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
// TODO - Combined with other VU in CC as IsExtEnabled is not needed
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-graphicsPipelineLibrary-06606", device,
create_info_loc.dot(Field::flags), "is (%s).", string_VkPipelineCreateFlags(flags).c_str());
}
skip |= ValidateStructTypeArray(create_info_loc.dot(Field::stageCount), create_info_loc.dot(Field::pStages),
"VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO", create_info.stageCount,
create_info.pStages, VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO, true,
true, "VUID-VkPipelineShaderStageCreateInfo-sType-sType",
"VUID-VkGraphicsPipelineCreateInfo-pStages-06600",
"VUID-VkGraphicsPipelineCreateInfo-pStages-06600");
// Can be null with enough dynamic states
skip |= ValidateStructType(
create_info_loc.dot(Field::pRasterizationState), "VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO",
create_info.pRasterizationState, VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO, false,
kVUIDUndefined, "VUID-VkPipelineRasterizationStateCreateInfo-sType-sType");
}
if ((flags & VK_PIPELINE_CREATE_RETAIN_LINK_TIME_OPTIMIZATION_INFO_BIT_EXT) != 0 &&
(flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) == 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-09245", device, create_info_loc.dot(Field::flags),
"is (%s).", string_VkPipelineCreateFlags(flags).c_str());
}
// <VkDynamicState, index in pDynamicStates, hash for enum key>
vvl::unordered_map<VkDynamicState, uint32_t, std::hash<int>> dynamic_state_map;
// TODO probably should check dynamic state from graphics libraries, at least when creating an "executable pipeline"
if (create_info.pDynamicState != nullptr) {
const auto &dynamic_state_info = *create_info.pDynamicState;
for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
const VkDynamicState dynamic_state = dynamic_state_info.pDynamicStates[state_index];
if (vvl::Contains(dynamic_state_map, dynamic_state)) {
skip |= LogError("VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442", device,
create_info_loc.dot(Field::pDynamicState),
"has %s at pDynamicStates[%" PRIu32 "] and pDynamicStates[%" PRIu32 "].",
string_VkDynamicState(dynamic_state), dynamic_state_map[dynamic_state], state_index);
}
dynamic_state_map[dynamic_state] = state_index;
}
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR)) {
// Not allowed for graphics pipelines
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03578", device,
create_info_loc.dot(Field::pDynamicState)
.dot(Field::pDynamicStates, dynamic_state_map[VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR]),
"is VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR.");
}
if (has_pre_raster_state && vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT) &&
vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT)) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132", device, create_info_loc.dot(Field::pDynamicState),
"pDynamicStates[%" PRIu32 "] is VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT and pDynamicStates[%" PRIu32
"] is VK_DYNAMIC_STATE_VIEWPORT.",
dynamic_state_map[VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT], dynamic_state_map[VK_DYNAMIC_STATE_VIEWPORT]);
}
if (has_pre_raster_state && vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT) &&
vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_SCISSOR)) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133", device, create_info_loc.dot(Field::pDynamicState),
"pDynamicStates[%" PRIu32 "] is VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT and pDynamicStates[%" PRIu32
"] is VK_DYNAMIC_STATE_SCISSOR.",
dynamic_state_map[VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT], dynamic_state_map[VK_DYNAMIC_STATE_SCISSOR]);
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_DISCARD_RECTANGLE_ENABLE_EXT) &&
discard_rectangles_extension_version < 2) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-07855", device,
create_info_loc.dot(Field::pDynamicState)
.dot(Field::pDynamicStates, dynamic_state_map[VK_DYNAMIC_STATE_DISCARD_RECTANGLE_ENABLE_EXT]),
"is VK_DYNAMIC_STATE_DISCARD_RECTANGLE_ENABLE_EXT without support for version 2 of VK_EXT_discard_rectangles.");
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_DISCARD_RECTANGLE_MODE_EXT) &&
discard_rectangles_extension_version < 2) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-07856", device,
create_info_loc.dot(Field::pDynamicState)
.dot(Field::pDynamicStates, dynamic_state_map[VK_DYNAMIC_STATE_DISCARD_RECTANGLE_MODE_EXT]),
"is VK_DYNAMIC_STATE_DISCARD_RECTANGLE_MODE_EXT without support for version 2 of VK_EXT_discard_rectangles.");
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_ENABLE_NV) &&
scissor_exclusive_extension_version < 2) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-07854", device,
create_info_loc.dot(Field::pDynamicState)
.dot(Field::pDynamicStates, dynamic_state_map[VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_ENABLE_NV]),
"is VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_ENABLE_NV without support for version 2 of VK_NV_scissor_exclusive.");
}
auto feedback_struct = vku::FindStructInPNextChain<VkPipelineCreationFeedbackCreateInfoEXT>(create_info.pNext);
if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 0 &&
feedback_struct->pipelineStageCreationFeedbackCount != create_info.stageCount)) {
skip |=
LogError("VUID-VkGraphicsPipelineCreateInfo-pipelineStageCreationFeedbackCount-06594", device,
create_info_loc.pNext(Struct::VkPipelineCreationFeedback, Field::pipelineStageCreationFeedbackCount),
"(%" PRIu32 ") is different than stageCount(%" PRIu32 ").",
feedback_struct->pipelineStageCreationFeedbackCount, create_info.stageCount);
}
// helpers for bool used multiple times below
const bool has_dynamic_viewport = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT);
const bool has_dynamic_scissor = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_SCISSOR);
const bool has_dynamic_viewport_w_scaling_nv = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV);
const bool has_dynamic_exclusive_scissor_nv = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV);
const bool has_dynamic_viewport_with_count = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT);
const bool has_dynamic_scissor_with_count = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT);
const bool has_dynamic_vertex_input = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VERTEX_INPUT_EXT);
// Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
// Collect active stages and other information
// Only want to loop through pStages once
uint32_t active_shaders = 0;
if (create_info.pStages != nullptr) {
for (uint32_t stage_index = 0; stage_index < create_info.stageCount; ++stage_index) {
active_shaders |= create_info.pStages[stage_index].stage;
const Location stage_loc = create_info_loc.dot(Field::pStages, stage_index);
skip |= ValidateRequiredPointer(stage_loc.dot(Field::pName), create_info.pStages[stage_index].pName,
"VUID-VkPipelineShaderStageCreateInfo-pName-parameter");
if (create_info.pStages[stage_index].pName) {
skip |= ValidateString(stage_loc.dot(Field::pName), "VUID-VkPipelineShaderStageCreateInfo-pName-parameter",
create_info.pStages[stage_index].pName);
}
ValidatePipelineShaderStageCreateInfo(&create_info.pStages[stage_index], stage_loc);
}
}
if (has_pre_raster_state && (active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
(active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) {
if (create_info.pTessellationState) {
skip |= ValidatePipelineTessellationStateCreateInfo(*create_info.pTessellationState, i, create_info_loc.dot(Field::pTessellationState));
if (create_info.pTessellationState->patchControlPoints == 0 ||
create_info.pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
skip |=
LogError("VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214", device,
create_info_loc.dot(Field::pTessellationState).dot(Field::patchControlPoints),
"%" PRIu32 ", but should between 0 and maxTessellationPatchSize (%" PRIu32 ").",
create_info.pTessellationState->patchControlPoints, device_limits.maxTessellationPatchSize);
}
} else if (!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT) ||
!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state3)) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pStages-09022", device, create_info_loc.dot(Field::pStages),
"includes a tessellation control "
"shader stage and a tessellation evaluation shader stage, "
"but pTessellationState is NULL.");
}
}
if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_EXT) && (create_info.pInputAssemblyState != nullptr)) {
skip |= ValidatePipelineInputAssemblyStateCreateInfo(*create_info.pInputAssemblyState, i,
create_info_loc.dot(Field::pInputAssemblyState));
}
if (!has_dynamic_vertex_input && !(active_shaders & VK_SHADER_STAGE_MESH_BIT_EXT) &&
(create_info.pVertexInputState != nullptr)) {
auto const &vertex_input_state = create_info.pVertexInputState;
const Location vertex_loc = create_info_loc.dot(Field::pVertexInputState);
skip |= ValidatePipelineVertexInputStateCreateInfo(*vertex_input_state, i, vertex_loc);
if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
skip |= LogError("VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613", device,
vertex_loc.dot(Field::vertexBindingDescriptionCount),
"(%" PRIu32 ") is larger than maxVertexInputBindings (%" PRIu32 ").",
vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
}
if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
skip |= LogError("VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614", device,
vertex_loc.dot(Field::vertexAttributeDescriptionCount),
"%" PRIu32 ") is larger than maxVertexInputAttributes (%" PRIu32 ").",
vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
}
vvl::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
const Location binding_loc = vertex_loc.dot(Field::pVertexBindingDescriptions);
auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
if (binding_it != vertex_bindings.cend()) {
skip |= LogError("VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616", device,
binding_loc.dot(Field::binding),
"(%" PRIu32 ") is already in pVertexBindingDescription[%" PRIu32 "].",
vertex_bind_desc.binding, *binding_it);
}
vertex_bindings.insert(vertex_bind_desc.binding);
if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
skip |=
LogError("VUID-VkVertexInputBindingDescription-binding-00618", device, binding_loc.dot(Field::binding),
"(%" PRIu32
") is larger than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
}
if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
skip |=
LogError("VUID-VkVertexInputBindingDescription-stride-00619", device, binding_loc.dot(Field::stride),
"(%" PRIu32
") is larger "
"than maxVertexInputBindingStride (%" PRIu32 ").",
vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
}
}
vvl::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
const Location attribute_loc = vertex_loc.dot(Field::pVertexAttributeDescriptions);
auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
if (location_it != attribute_locations.cend()) {
skip |= LogError("VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617", device,
attribute_loc.dot(Field::location),
"(%" PRIu32 ") is already in pVertexAttributeDescriptions[%" PRIu32 "].",
vertex_attrib_desc.location, *location_it);
}
attribute_locations.insert(vertex_attrib_desc.location);
auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
if (binding_it == vertex_bindings.cend()) {
skip |= LogError("VUID-VkPipelineVertexInputStateCreateInfo-binding-00615", device,
attribute_loc.dot(Field::binding),
"(%" PRIu32 ") does not exist in pVertexBindingDescription.", vertex_attrib_desc.binding);
}
if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
skip |= LogError("VUID-VkVertexInputAttributeDescription-location-00620", device,
attribute_loc.dot(Field::location),
"(%" PRIu32 ") is larger than or equal to maxVertexInputAttributes (%" PRIu32 ").",
vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
}
if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
skip |= LogError("VUID-VkVertexInputAttributeDescription-binding-00621", device,
attribute_loc.dot(Field::binding),
"(%" PRIu32 ") is larger than or equal to maxVertexInputBindings (%" PRIu32 ").",
vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
}
if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
skip |= LogError("VUID-VkVertexInputAttributeDescription-offset-00622", device,
attribute_loc.dot(Field::offset),
"(%" PRIu32 ") is larger than maxVertexInputAttributeOffset (%" PRIu32 ").",
vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
}
VkFormatProperties properties;
DispatchGetPhysicalDeviceFormatProperties(physical_device, vertex_attrib_desc.format, &properties);
if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) {
skip |= LogError("VUID-VkVertexInputAttributeDescription-format-00623", device,
attribute_loc.dot(Field::format),
"(%s) is not a supported vertex buffer format (supported bufferFeatures: %s).",
string_VkFormat(vertex_attrib_desc.format),
string_VkFormatFeatureFlags2(properties.bufferFeatures).c_str());
}
}
}
// pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
if ((create_info.pRasterizationState != nullptr) &&
(create_info.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
// Everything in here has a pre-rasterization shader state
if (create_info.pViewportState) {
const auto &viewport_state = *create_info.pViewportState;
const Location viewport_loc = create_info_loc.dot(Field::pViewportState);
skip |= ValidatePipelineViewportStateCreateInfo(*create_info.pViewportState, i, viewport_loc);
const auto *exclusive_scissor_struct =
vku::FindStructInPNextChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(viewport_state.pNext);
const auto *shading_rate_image_struct =
vku::FindStructInPNextChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(viewport_state.pNext);
const auto *coarse_sample_order_struct =
vku::FindStructInPNextChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(viewport_state.pNext);
const auto *vp_swizzle_struct =
vku::FindStructInPNextChain<VkPipelineViewportSwizzleStateCreateInfoNV>(viewport_state.pNext);
const auto *vp_w_scaling_struct =
vku::FindStructInPNextChain<VkPipelineViewportWScalingStateCreateInfoNV>(viewport_state.pNext);
const auto *depth_clip_control_struct =
vku::FindStructInPNextChain<VkPipelineViewportDepthClipControlCreateInfoEXT>(viewport_state.pNext);
if (!physical_device_features.multiViewport) {
if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
exclusive_scissor_struct->exclusiveScissorCount != 1)) {
skip |= LogError("VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
device,
viewport_loc.pNext(Struct::VkPipelineViewportExclusiveScissorStateCreateInfoNV,
Field::exclusiveScissorCount),
"is %" PRIu32 " but multiViewport feature is not enabled.",
exclusive_scissor_struct->exclusiveScissorCount);
}
if (shading_rate_image_struct &&
(shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
skip |= LogError("VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054", device,
viewport_loc.pNext(Struct::VkPipelineViewportShadingRateImageStateCreateInfoNV,
Field::viewportCount),
"is %" PRIu32 " but multiViewport feature is not enabled.",
shading_rate_image_struct->viewportCount);
}
}
// Viewport count
if (viewport_state.viewportCount > device_limits.maxViewports) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218", device,
viewport_loc.dot(Field::viewportCount),
"(%" PRIu32 ") is larger than maxViewports (%" PRIu32 ").", viewport_state.viewportCount,
device_limits.maxViewports);
}
if (has_dynamic_viewport_with_count) {
if (viewport_state.viewportCount != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379", device,
viewport_loc.dot(Field::viewportCount),
"(%" PRIu32 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT is used.",
viewport_state.viewportCount);
}
} else {
if (viewport_state.viewportCount == 0) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-viewportCount-04135", device,
viewport_loc.dot(Field::viewportCount),
"can't be 0 unless VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT is used.");
}
if (!physical_device_features.multiViewport && (viewport_state.viewportCount > 1)) {
skip |=
LogError("VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216", device,
viewport_loc.dot(Field::viewportCount),
"is %" PRIu32 " but multiViewport feature is not enabled.", viewport_state.viewportCount);
}
}
// Scissor count
if (viewport_state.scissorCount > device_limits.maxViewports) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219", device,
viewport_loc.dot(Field::scissorCount),
"(%" PRIu32 ") is larger than maxViewports (%" PRIu32 ").", viewport_state.scissorCount,
device_limits.maxViewports);
}
if (has_dynamic_scissor_with_count) {
if (viewport_state.scissorCount != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380", device,
viewport_loc.dot(Field::scissorCount),
"(%" PRIu32 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT is used.",
viewport_state.viewportCount);
}
} else {
if (viewport_state.scissorCount == 0) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136", device,
viewport_loc.dot(Field::scissorCount),
"can't be 0 unless VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT is used.");
}
if (!physical_device_features.multiViewport && (viewport_state.scissorCount > 1)) {
skip |=
LogError("VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217", device,
viewport_loc.dot(Field::scissorCount),
"is %" PRIu32 " but multiViewport feature is not enabled.", viewport_state.scissorCount);
}
}
if (!has_dynamic_scissor && viewport_state.pScissors) {
for (uint32_t scissor_i = 0; scissor_i < viewport_state.scissorCount; ++scissor_i) {
const Location &scissor_loc = create_info_loc.dot(Field::pScissors, scissor_i);
const auto &scissor = viewport_state.pScissors[scissor_i];
if (scissor.offset.x < 0) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-x-02821", device,
scissor_loc.dot(Field::offset).dot(Field::x), "(%" PRId32 ") is negative.",
scissor.offset.x);
}
if (scissor.offset.y < 0) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-x-02821", device,
scissor_loc.dot(Field::offset).dot(Field::y), "(%" PRId32 ") is negative.",
scissor.offset.y);
}
const int64_t x_sum =
static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
if (x_sum > std::numeric_limits<int32_t>::max()) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-offset-02822", device, scissor_loc,
"offset.x (%" PRId32 ") + extent.width (%" PRId32 ") is %" PRIi64
" which will overflow int32_t.",
scissor.offset.x, scissor.extent.width, x_sum);
}
const int64_t y_sum =
static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
if (y_sum > std::numeric_limits<int32_t>::max()) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-offset-02823", device, scissor_loc,
"offset.y (%" PRId32 ") + extent.height (%" PRId32 ") is %" PRIi64
" which will overflow int32_t.",
scissor.offset.y, scissor.extent.height, y_sum);
}
}
}
if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
skip |=
LogError("VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028", device,
viewport_loc.pNext(Struct::VkPipelineViewportExclusiveScissorStateCreateInfoNV,
Field::exclusiveScissorCount),
"(%" PRIu32 ") is larger than maxViewports (%" PRIu32 ").",
exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
}
if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
skip |= LogError(
"VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055", device,
viewport_loc.pNext(Struct::VkPipelineViewportShadingRateImageStateCreateInfoNV, Field::viewportCount),
"(%" PRIu32 ") is larger than maxViewports (%" PRIu32 ").", shading_rate_image_struct->viewportCount,
device_limits.maxViewports);
}
if (viewport_state.scissorCount != viewport_state.viewportCount) {
if (!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state) ||
(!has_dynamic_viewport_with_count && !has_dynamic_scissor_with_count)) {
skip |= LogError("VUID-VkPipelineViewportStateCreateInfo-scissorCount-04134", device, viewport_loc,
"scissorCount (%" PRIu32 ") is different to viewportCount (%" PRIu32 ").",
viewport_state.scissorCount, viewport_state.viewportCount);
}
}
if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
skip |=
LogError("VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029", device,
viewport_loc.pNext(Struct::VkPipelineViewportExclusiveScissorStateCreateInfoNV,
Field::exclusiveScissorCount),
"is %" PRIu32 " and viewportCount is (%" PRIu32 ").",
exclusive_scissor_struct->exclusiveScissorCount, viewport_state.viewportCount);
}
if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
shading_rate_image_struct->viewportCount > viewport_state.viewportCount) {
skip |= LogError(
"VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056", device,
viewport_loc.pNext(Struct::VkPipelineViewportShadingRateImageStateCreateInfoNV, Field::viewportCount),
"(%" PRIu32 ") is greater than viewportCount (%" PRIu32 ").", shading_rate_image_struct->viewportCount,
viewport_state.viewportCount);
}
if (!has_dynamic_viewport && !has_dynamic_viewport_with_count && viewport_state.viewportCount > 0 &&
viewport_state.pViewports == nullptr) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04130", device,
viewport_loc.dot(Field::pViewports), "is NULL, but the viewport state is not dynamic.");
}
if (!has_dynamic_scissor && !has_dynamic_scissor_with_count && viewport_state.scissorCount > 0 &&
viewport_state.pScissors == nullptr) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04131", device,
viewport_loc.dot(Field::pScissors), "is NULL, but the scissor state is is not dynamic.");
}
if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
exclusive_scissor_struct->exclusiveScissorCount > 0 &&
exclusive_scissor_struct->pExclusiveScissors == nullptr) {
skip |=
LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056", device, viewport_loc,
"The exclusive scissor state is static (pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
"pCreateInfos[%" PRIu32 "] pExclusiveScissors is NULL.",
i, i);
}
if (!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) &&
shading_rate_image_struct && shading_rate_image_struct->viewportCount > 0 &&
shading_rate_image_struct->pShadingRatePalettes == nullptr) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057", device, viewport_loc,
"The shading rate palette state is static (pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
"but pCreateInfos[%" PRIu32 "] pShadingRatePalettes is NULL.",
i, i);
}
if (vp_swizzle_struct) {
const auto swizzle_viewport_count = vp_swizzle_struct->viewportCount;
const auto viewport_count = viewport_state.viewportCount;
if (swizzle_viewport_count < viewport_count) {
skip |= LogError(
"VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215", device,
viewport_loc.pNext(Struct::VkPipelineViewportSwizzleStateCreateInfoNV, Field::viewportCount),
"(%" PRIu32 ") less than viewportCount (%" PRIu32 ").", swizzle_viewport_count, viewport_count);
}
}
// validate the VkViewports
if (!has_dynamic_viewport && viewport_state.pViewports) {
for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
skip |= ValidateViewport(viewport, VkCommandBuffer(0), viewport_loc.dot(Field::pViewports, viewport_i));
}
}
if (has_dynamic_viewport_w_scaling_nv && !IsExtEnabled(device_extensions.vk_nv_clip_space_w_scaling)) {
skip |= LogError(kVUID_PVError_ExtensionNotEnabled, device, create_info_loc,
"pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
"VK_NV_clip_space_w_scaling extension is not enabled.",
i);
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) &&
!IsExtEnabled(device_extensions.vk_ext_discard_rectangles)) {
skip |= LogError(kVUID_PVError_ExtensionNotEnabled, device, create_info_loc,
"pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
"VK_EXT_discard_rectangles extension is not enabled.",
i);
}
if (vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) &&
!IsExtEnabled(device_extensions.vk_ext_sample_locations)) {
skip |= LogError(kVUID_PVError_ExtensionNotEnabled, device, create_info_loc,
"pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
"VK_EXT_sample_locations extension is not enabled.",
i);
}
if (has_dynamic_exclusive_scissor_nv && !IsExtEnabled(device_extensions.vk_nv_scissor_exclusive)) {
skip |= LogError(kVUID_PVError_ExtensionNotEnabled, device, create_info_loc,
"pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
"VK_NV_scissor_exclusive extension is not enabled.",
i);
}
if (coarse_sample_order_struct) {
const Location coarse_sample_loc =
viewport_loc.pNext(Struct::VkPipelineViewportCoarseSampleOrderStateCreateInfoNV);
if (coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
coarse_sample_order_struct->customSampleOrderCount != 0) {
skip |= LogError("VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
device, coarse_sample_loc.dot(Field::sampleOrderType),
"is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.");
}
for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i],
coarse_sample_loc.dot(Field::pCustomSampleOrders, order_i));
}
}
if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
skip |= LogError(
"VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726", device,
viewport_loc.pNext(Struct::VkPipelineViewportWScalingStateCreateInfoNV, Field::viewportCount),
"(%" PRIu32 ") is not equal to viewportCount (%" PRIu32 ").", vp_w_scaling_struct->viewportCount,
viewport_state.viewportCount);
}
if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715", device,
viewport_loc.pNext(Struct::VkPipelineViewportWScalingStateCreateInfoNV, Field::pViewportWScalings),
"is NULL.");
}
}
if (depth_clip_control_struct) {
const auto *depth_clip_control_features =
vku::FindStructInPNextChain<VkPhysicalDeviceDepthClipControlFeaturesEXT>(device_createinfo_pnext);
const bool enabled_depth_clip_control =
depth_clip_control_features && depth_clip_control_features->depthClipControl;
if (depth_clip_control_struct->negativeOneToOne && !enabled_depth_clip_control) {
skip |= LogError(
"VUID-VkPipelineViewportDepthClipControlCreateInfoEXT-negativeOneToOne-06470", device,
viewport_loc.pNext(Struct::VkPhysicalDeviceDepthClipControlFeaturesEXT, Field::negativeOneToOne),
"is VK_TRUE but the depthClipControl feature was not enabled.");
}
}
} else if (!has_dynamic_viewport_with_count || !has_dynamic_scissor_with_count ||
!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state3)) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-09024", device, create_info_loc,
"Rasterization is enabled (pCreateInfos[%" PRIu32
"].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
"].pViewportState is NULL.",
i, i);
}
// It is possible for pCreateInfos[i].pMultisampleState to be null when creating a graphics library
if (create_info.pMultisampleState) {
const Location ms_loc = create_info_loc.dot(Field::pMultisampleState);
skip |= ValidatePipelineMultisampleStateCreateInfo(*create_info.pMultisampleState, i, ms_loc);
if (create_info.pMultisampleState->sampleShadingEnable == VK_TRUE) {
if (!physical_device_features.sampleRateShading) {
skip |= LogError("VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784", device,
ms_loc.dot(Field::sampleShadingEnable),
"is VK_TRUE but the sampleRateShading feature was not enabled.");
}
// TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
// For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
if (!IsBetweenInclusive(create_info.pMultisampleState->minSampleShading, 0.F, 1.0F)) {
skip |= LogError("VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786", device,
ms_loc.dot(Field::minSampleShading), "is %f.",
create_info.pMultisampleState->minSampleShading);
}
}
}
bool uses_color_attachment = false;
bool uses_depthstencil_attachment = false;
VkSubpassDescriptionFlags subpass_flags = 0;
{
std::unique_lock<std::mutex> lock(renderpass_map_mutex);
const auto subpasses_uses_it = renderpasses_states.find(create_info.renderPass);
if (subpasses_uses_it != renderpasses_states.end()) {
const auto &subpasses_uses = subpasses_uses_it->second;
if (subpasses_uses.subpasses_using_color_attachment.count(create_info.subpass)) {
uses_color_attachment = true;
}
if (subpasses_uses.subpasses_using_depthstencil_attachment.count(create_info.subpass)) {
uses_depthstencil_attachment = true;
}
if (create_info.subpass < subpasses_uses.subpasses_flags.size()) {
subpass_flags = subpasses_uses.subpasses_flags[create_info.subpass];
}
color_attachment_count = subpasses_uses.color_attachment_count;
}
lock.unlock();
}
if (create_info.pDepthStencilState != nullptr && uses_depthstencil_attachment) {
const Location ds_loc = create_info_loc.dot(Field::pDepthStencilState);
skip |= ValidatePipelineDepthStencilStateCreateInfo(*create_info.pDepthStencilState, i, ds_loc);
if ((create_info.pDepthStencilState->flags &
VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) != 0) {
const auto *rasterization_order_attachment_access_feature =
vku::FindStructInPNextChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
const bool rasterization_order_depth_attachment_access_feature_enabled =
rasterization_order_attachment_access_feature &&
rasterization_order_attachment_access_feature->rasterizationOrderDepthAttachmentAccess == VK_TRUE;
if (!rasterization_order_depth_attachment_access_feature_enabled) {
skip |= LogError(
"VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderDepthAttachmentAccess-06463", device,
ds_loc,
"VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
"rasterizationOrderDepthAttachmentAccess == VK_FALSE, but "
"VkPipelineDepthStencilStateCreateInfo::flags == %s",
string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
}
if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) == 0) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-flags-06485", device, ds_loc,
"VkPipelineDepthStencilStateCreateInfo::flags == %s but "
"VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
string_VkSubpassDescriptionFlags(subpass_flags).c_str());
}
}
if ((create_info.pDepthStencilState->flags &
VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) != 0) {
const auto *rasterization_order_attachment_access_feature =
vku::FindStructInPNextChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
const bool rasterization_order_stencil_attachment_access_feature_enabled =
rasterization_order_attachment_access_feature &&
rasterization_order_attachment_access_feature->rasterizationOrderStencilAttachmentAccess == VK_TRUE;
if (!rasterization_order_stencil_attachment_access_feature_enabled) {
skip |= LogError(
"VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderStencilAttachmentAccess-06464",
device, ds_loc,
"VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
"rasterizationOrderStencilAttachmentAccess == VK_FALSE, but "
"VkPipelineDepthStencilStateCreateInfo::flags == %s",
string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
}
if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) == 0) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-flags-06486", device, ds_loc,
"VkPipelineDepthStencilStateCreateInfo::flags == %s but "
"VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
string_VkSubpassDescriptionFlags(subpass_flags).c_str());
}
}
}
if (create_info.pColorBlendState != nullptr && uses_color_attachment) {
const Location color_loc = create_info_loc.dot(Field::pColorBlendState);
auto const &color_blend_state = *create_info.pColorBlendState;
skip |= ValidatePipelineColorBlendStateCreateInfo(color_blend_state, i, color_loc);
if ((color_blend_state.flags &
VK_PIPELINE_COLOR_BLEND_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_ACCESS_BIT_ARM) != 0) {
const auto *rasterization_order_attachment_access_feature =
vku::FindStructInPNextChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
const bool rasterization_order_color_attachment_access_feature_enabled =
rasterization_order_attachment_access_feature &&
rasterization_order_attachment_access_feature->rasterizationOrderColorAttachmentAccess == VK_TRUE;
if (!rasterization_order_color_attachment_access_feature_enabled) {
skip |=
LogError("VUID-VkPipelineColorBlendStateCreateInfo-rasterizationOrderColorAttachmentAccess-06465",
device, color_loc,
"VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
"rasterizationColorAttachmentAccess == VK_FALSE, but "
"VkPipelineColorBlendStateCreateInfo::flags == %s",
string_VkPipelineColorBlendStateCreateFlags(color_blend_state.flags).c_str());
}
if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_COLOR_ACCESS_BIT_ARM) == 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-06484", device, color_loc,
"VkPipelineColorBlendStateCreateInfo::flags == %s but "
"VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
string_VkPipelineColorBlendStateCreateFlags(color_blend_state.flags).c_str(),
string_VkSubpassDescriptionFlags(subpass_flags).c_str());
}
}
if (color_blend_state.pAttachments != nullptr) {
const VkBlendOp first_color_blend_op = color_blend_state.pAttachments[0].colorBlendOp;
const VkBlendOp first_alpha_blend_op = color_blend_state.pAttachments[0].alphaBlendOp;
for (uint32_t attachment_index = 0; attachment_index < color_blend_state.attachmentCount;
++attachment_index) {
const Location attachment_loc = color_loc.dot(Field::pAttachments, attachment_index);
const VkPipelineColorBlendAttachmentState attachment_state =
color_blend_state.pAttachments[attachment_index];
skip |=
ValidatePipelineColorBlendAttachmentState(attachment_state, i, attachment_index, attachment_loc);
// if blendEnabled is false, these values are ignored
if (attachment_state.blendEnable) {
bool advance_blend = false;
if (IsAdvanceBlendOperation(attachment_state.colorBlendOp)) {
advance_blend = true;
if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendAllOperations == VK_FALSE) {
// This VUID checks if a subset of advance blend ops are allowed
switch (attachment_state.colorBlendOp) {
case VK_BLEND_OP_ZERO_EXT:
case VK_BLEND_OP_SRC_EXT:
case VK_BLEND_OP_DST_EXT:
case VK_BLEND_OP_SRC_OVER_EXT:
case VK_BLEND_OP_DST_OVER_EXT:
case VK_BLEND_OP_SRC_IN_EXT:
case VK_BLEND_OP_DST_IN_EXT:
case VK_BLEND_OP_SRC_OUT_EXT:
case VK_BLEND_OP_DST_OUT_EXT:
case VK_BLEND_OP_SRC_ATOP_EXT:
case VK_BLEND_OP_DST_ATOP_EXT:
case VK_BLEND_OP_XOR_EXT:
case VK_BLEND_OP_INVERT_EXT:
case VK_BLEND_OP_INVERT_RGB_EXT:
case VK_BLEND_OP_LINEARDODGE_EXT:
case VK_BLEND_OP_LINEARBURN_EXT:
case VK_BLEND_OP_VIVIDLIGHT_EXT:
case VK_BLEND_OP_LINEARLIGHT_EXT:
case VK_BLEND_OP_PINLIGHT_EXT:
case VK_BLEND_OP_HARDMIX_EXT:
case VK_BLEND_OP_PLUS_EXT:
case VK_BLEND_OP_PLUS_CLAMPED_EXT:
case VK_BLEND_OP_PLUS_CLAMPED_ALPHA_EXT:
case VK_BLEND_OP_PLUS_DARKER_EXT:
case VK_BLEND_OP_MINUS_EXT:
case VK_BLEND_OP_MINUS_CLAMPED_EXT:
case VK_BLEND_OP_CONTRAST_EXT:
case VK_BLEND_OP_INVERT_OVG_EXT:
case VK_BLEND_OP_RED_EXT:
case VK_BLEND_OP_GREEN_EXT:
case VK_BLEND_OP_BLUE_EXT: {
skip |= LogError(
"VUID-VkPipelineColorBlendAttachmentState-advancedBlendAllOperations-01409",
device, attachment_loc.dot(Field::colorBlendOp),
"(%s) but "
"VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT::"
"advancedBlendAllOperations is "
"VK_FALSE",
string_VkBlendOp(attachment_state.colorBlendOp));
break;
}
default:
break;
}
}
if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendIndependentBlend ==
VK_FALSE &&
attachment_state.colorBlendOp != first_color_blend_op) {
skip |= LogError(
"VUID-VkPipelineColorBlendAttachmentState-advancedBlendIndependentBlend-01407", device,
attachment_loc.dot(Field::colorBlendOp), "(%s) is not same the other attachments (%s).",
string_VkBlendOp(attachment_state.colorBlendOp),
string_VkBlendOp(first_color_blend_op));
}
}
if (IsAdvanceBlendOperation(attachment_state.alphaBlendOp)) {
advance_blend = true;
if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendIndependentBlend ==
VK_FALSE &&
attachment_state.alphaBlendOp != first_alpha_blend_op) {
skip |= LogError(
"VUID-VkPipelineColorBlendAttachmentState-advancedBlendIndependentBlend-01408", device,
attachment_loc.dot(Field::alphaBlendOp), "(%s) is not same the other attachments (%s).",
string_VkBlendOp(attachment_state.alphaBlendOp),
string_VkBlendOp(first_alpha_blend_op));
}
}
if (advance_blend) {
if (attachment_state.colorBlendOp != attachment_state.alphaBlendOp) {
skip |= LogError("VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-01406", device,
attachment_loc,
"has different colorBlendOp (%s) and alphaBlendOp (%s) but one of "
"them is an advance blend operation.",
string_VkBlendOp(attachment_state.colorBlendOp),
string_VkBlendOp(attachment_state.alphaBlendOp));
} else if (color_attachment_count >
phys_dev_ext_props.blend_operation_advanced_props.advancedBlendMaxColorAttachments) {
// color_attachment_count is found one of multiple spots above
//
// error can guarantee it is the same VkBlendOp
skip |= LogError(
"VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-01410", device, attachment_loc,
"has an advance blend operation (%s) but the colorAttachmentCount (%" PRIu32
") for the subpass is larger than advancedBlendMaxColorAttachments (%" PRIu32 ").",
string_VkBlendOp(attachment_state.colorBlendOp), color_attachment_count,
phys_dev_ext_props.blend_operation_advanced_props.advancedBlendMaxColorAttachments);
break; // if this fails once, will fail every iteration
}
}
}
}
}
// If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
if (color_blend_state.logicOpEnable == VK_TRUE) {
skip |= ValidateRangedEnum(color_loc.dot(Field::logicOp), "VkLogicOp", color_blend_state.logicOp,
"VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
}
const bool dynamic_not_set = (!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_COLOR_BLEND_ADVANCED_EXT) ||
!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_COLOR_BLEND_ENABLE_EXT) ||
!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_COLOR_BLEND_EQUATION_EXT) ||
!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_COLOR_WRITE_MASK_EXT));
// If any of the dynamic states are not set still need a valid array
if ((color_blend_state.attachmentCount > 0) && dynamic_not_set) {
skip |= ValidateArray(color_loc.dot(Field::attachmentCount), color_loc.dot(Field::pAttachments),
color_blend_state.attachmentCount, &color_blend_state.pAttachments, false, true,
kVUIDUndefined, "VUID-VkPipelineColorBlendStateCreateInfo-pAttachments-07353");
}
auto color_write = vku::FindStructInPNextChain<VkPipelineColorWriteCreateInfoEXT>(color_blend_state.pNext);
if (color_write && (color_write->attachmentCount != color_blend_state.attachmentCount) && dynamic_not_set) {
skip |= LogError("VUID-VkPipelineColorWriteCreateInfoEXT-attachmentCount-07608", device,
color_loc.pNext(Struct::VkPipelineColorWriteCreateInfoEXT, Field::attachmentCount),
"(%" PRIu32 ") is different than pColorBlendState.attachmentCount (%" PRIu32 ").",
color_write->attachmentCount, color_blend_state.attachmentCount);
}
}
}
if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
if (create_info.basePipelineHandle != VK_NULL_HANDLE) {
if (create_info.basePipelineIndex != -1) {
skip |= LogError(
"VUID-VkGraphicsPipelineCreateInfo-flags-07986", device, create_info_loc.dot(Field::basePipelineIndex),
"%" PRIu32 " and basePipelineHandle is not VK_NULL_HANDLE.", pCreateInfos[i].basePipelineIndex);
}
} else {
if (static_cast<uint32_t>(create_info.basePipelineIndex) >= createInfoCount) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-07985", device,
create_info_loc.dot(Field::basePipelineIndex),
"(%" PRIu32 ") is greater than or equal to createInfoCount %" PRIu32 ".",
create_info.basePipelineIndex, createInfoCount);
}
}
}
if (create_info.pRasterizationState) {
const Location rasterization_loc = create_info_loc.dot(Field::pRasterizationState);
if (!IsExtEnabled(device_extensions.vk_nv_fill_rectangle)) {
if (create_info.pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
skip |= LogError("VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414", device,
rasterization_loc.dot(Field::polygonMode),
"is VK_POLYGON_MODE_FILL_RECTANGLE_NV, but "
"the extension VK_NV_fill_rectangle is not enabled.");
}
}
if ((create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
(create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
(physical_device_features.fillModeNonSolid == false)) {
skip |=
LogError("VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507", device,
rasterization_loc.dot(Field::polygonMode), "is %s, but fillModeNonSolid feature is note enabled.",
string_VkPolygonMode(create_info.pRasterizationState->polygonMode));
}
if (!vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_LINE_WIDTH) && !physical_device_features.wideLines &&
(create_info.pRasterizationState->lineWidth != 1.0f)) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749", device,
rasterization_loc.dot(Field::lineWidth),
"is %f, but the line width state is static (pCreateInfos[%" PRIu32
"].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
"wideLines feature was not enabled.",
create_info.pRasterizationState->lineWidth, i);
}
const auto *line_state =
vku::FindStructInPNextChain<VkPipelineRasterizationLineStateCreateInfoEXT>(create_info.pRasterizationState->pNext);
const bool dynamic_line_raster_mode =
vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_LINE_RASTERIZATION_MODE_EXT);
const bool dynamic_line_stipple_enable = vvl::Contains(dynamic_state_map, VK_DYNAMIC_STATE_LINE_STIPPLE_ENABLE_EXT);
if (line_state) {
if (line_state->stippledLineEnable && !dynamic_line_stipple_enable) {
if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767", device,
rasterization_loc.pNext(Struct::VkPipelineRasterizationLineStateCreateInfoEXT,
Field::lineStippleFactor),
"is %" PRIu32 ".", line_state->lineStippleFactor);
}
}
if (!dynamic_line_raster_mode) {
if (create_info.pMultisampleState &&
(line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
if (create_info.pMultisampleState->alphaToCoverageEnable) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766", device,
rasterization_loc.pNext(Struct::VkPipelineRasterizationLineStateCreateInfoEXT,
Field::lineStippleFactor),
"is %s, but pCreateInfos[%" PRIu32
"].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
string_VkLineRasterizationModeEXT(line_state->lineRasterizationMode), i);
}
if (create_info.pMultisampleState->alphaToOneEnable) {
skip |=
LogError("VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766", device,
rasterization_loc.pNext(Struct::VkPipelineRasterizationLineStateCreateInfoEXT,
Field::lineStippleFactor),
"is %s, but pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToOneEnable == VK_TRUE.",
string_VkLineRasterizationModeEXT(line_state->lineRasterizationMode), i);
}
if (create_info.pMultisampleState->sampleShadingEnable) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766", device,
rasterization_loc.pNext(Struct::VkPipelineRasterizationLineStateCreateInfoEXT,
Field::lineStippleFactor),
"is %s, but pCreateInfos[%" PRIu32
"].pMultisampleState->sampleShadingEnable == VK_TRUE.",
string_VkLineRasterizationModeEXT(line_state->lineRasterizationMode), i);
}
}
const auto *line_features =
vku::FindStructInPNextChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
(!line_features || !line_features->rectangularLines)) {
skip |= LogError(
"VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT but the rectangularLines feature was not enabled.");
}
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
(!line_features || !line_features->bresenhamLines)) {
skip |= LogError(
"VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT but the bresenhamLines feature was not enabled.");
}
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
(!line_features || !line_features->smoothLines)) {
skip |=
LogError("VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT but the smoothLines feature was not "
"enabled.");
}
if (line_state->stippledLineEnable && !dynamic_line_stipple_enable) {
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
(!line_features || !line_features->stippledRectangularLines)) {
skip |=
LogError("VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT and stippledLineEnable was VK_TRUE, "
"but the stippledRectangularLines feature was not enabled.");
}
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
(!line_features || !line_features->stippledBresenhamLines)) {
skip |=
LogError("VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT and stippledLineEnable was VK_TRUE, but "
"the stippledBresenhamLines feature was not enabled.");
}
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
(!line_features || !line_features->stippledSmoothLines)) {
skip |=
LogError("VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT and stippledLineEnable was "
"VK_TRUE, but the stippledSmoothLines feature was not enabled.");
}
if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
(!line_features || !line_features->stippledRectangularLines || !device_limits.strictLines)) {
skip |=
LogError("VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774", device,
rasterization_loc.pNext(Struct::VkPhysicalDeviceLineRasterizationFeaturesEXT,
Field::lineRasterizationMode),
"is VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT and stippledLineEnable was VK_TRUE, but "
"the stippledRectangularLines feature was not enabled.");
}
}
}
}
}
// Validate no flags not allowed are used
if ((flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-00764", device, create_info_loc.dot(Field::flags),
"(%s) must not include "
"VK_PIPELINE_CREATE_DISPATCH_BASE.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03372", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03373", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03374", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03375", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03376", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03377", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-03577", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
skip |= LogError("VUID-VkGraphicsPipelineCreateInfo-flags-04947", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
string_VkPipelineCreateFlags(flags).c_str());
}
}
}
return skip;
}
bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
uint32_t createInfoCount,
const VkComputePipelineCreateInfo *pCreateInfos,
const VkAllocationCallbacks *pAllocator,
VkPipeline *pPipelines, const ErrorObject &error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < createInfoCount; i++) {
const Location create_info_loc = error_obj.location.dot(Field::pCreateInfos, i);
skip |= ValidateString(create_info_loc.dot(Field::stage).dot(Field::pName),
"VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
auto feedback_struct = vku::FindStructInPNextChain<VkPipelineCreationFeedbackCreateInfo>(pCreateInfos[i].pNext);
if (feedback_struct) {
const uint32_t feedback_count = feedback_struct->pipelineStageCreationFeedbackCount;
if ((feedback_count != 0) && (feedback_count != 1)) {
skip |= LogError(
"VUID-VkComputePipelineCreateInfo-pipelineStageCreationFeedbackCount-06566", device,
create_info_loc.pNext(Struct::VkPipelineCreationFeedbackCreateInfo, Field::pipelineStageCreationFeedbackCount),
"is %" PRIu32 ".", feedback_count);
}
}
// Make sure compute stage is selected
if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-stage-00701", device,
create_info_loc.dot(Field::stage).dot(Field::stage), "is %s.",
string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
}
const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
// Validate no flags not allowed are used
if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
const auto *shader_enqueue_features =
vku::FindStructInPNextChain<VkPhysicalDeviceShaderEnqueueFeaturesAMDX>(device_createinfo_pnext);
if (!shader_enqueue_features || shader_enqueue_features->shaderEnqueue) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-shaderEnqueue-09177", device, create_info_loc.dot(Field::flags),
"%s must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03365", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03366", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03367", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03368", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03369", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03370", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-03576", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-04945", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_OPACITY_MICROMAP_BIT_EXT) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-07367", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_OPACITY_MICROMAP_BIT_EXT.",
string_VkPipelineCreateFlags(flags).c_str());
}
if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_DISPLACEMENT_MICROMAP_BIT_NV) != 0) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-07996", device, create_info_loc.dot(Field::flags),
"(%s) must not include VK_PIPELINE_CREATE_RAY_TRACING_DISPLACEMENT_MICROMAP_BIT_NV.",
string_VkPipelineCreateFlags(flags).c_str());
}
if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
if (pCreateInfos[i].basePipelineIndex != -1) {
skip |= LogError(
"VUID-VkComputePipelineCreateInfo-flags-07986", device, create_info_loc.dot(Field::basePipelineIndex),
"(%" PRIu32 ") and basePipelineHandle is not VK_NULL_HANDLE.", pCreateInfos[i].basePipelineIndex);
}
} else {
if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
skip |= LogError("VUID-VkComputePipelineCreateInfo-flags-07985", device,
create_info_loc.dot(Field::basePipelineIndex),
"(%" PRIu32 ") is greater than or equal to createInfoCount %" PRIu32 ".",
pCreateInfos[i].basePipelineIndex, createInfoCount);
}
}
}
ValidatePipelineShaderStageCreateInfo(&pCreateInfos[i].stage, create_info_loc.dot(Field::stage));
}
return skip;
}
bool StatelessValidation::manual_PreCallValidateMergePipelineCaches(VkDevice device, VkPipelineCache dstCache,
uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches,
const ErrorObject &error_obj) const {
bool skip = false;
if (pSrcCaches) {
for (uint32_t index0 = 0; index0 < srcCacheCount; ++index0) {
if (pSrcCaches[index0] == dstCache) {
skip |= LogError("VUID-vkMergePipelineCaches-dstCache-00770", instance, error_obj.location.dot(Field::dstCache),
"%s is in pSrcCaches list.", FormatHandle(dstCache).c_str());
break;
}
}
}
return skip;
}