commit 9b4660b1542f56b82a0341787fe429d4ffe994c4
author Samuel Iglesias Gonsálvez <siglesias@igalia.com> Thu Oct 21 08:50:39 2021 +0200
committer ziga-lunarg <87310389+ziga-lunarg@users.noreply.github.com> Thu Oct 21 12:38:59 2021 +0200
tree 21910c53a2ccb6838a1d8b963554de27a51de269
parent a9d229bdae6d98eeb3e1ae03bf48c49f60d96547

syncval: Fix assert expression

GCC 11.1 printed out this warning:

../layers/synchronization_validation.cpp: In member function ‘void
ResourceAccessState::TouchupFirstForLayoutTransition(ResourceUsageTag,
const ResourceAccessState::OrderingBar
rier&)’:
../layers/synchronization_validation.cpp:3326:51: warning: suggest
parentheses around assignment used as truth value [-Wparentheses]
 3326 |         assert(first_accesses_.back().usage_index =
 SyncStageAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION);
       |
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

This looks like an error in the code.

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

layers/synchronization_validation.cpp

diff --git a/layers/synchronization_validation.cpp b/layers/synchronization_validation.cpp
index 81d50e9..4b0d552 100644
--- a/layers/synchronization_validation.cpp
+++ b/layers/synchronization_validation.cpp
@@ -3323,7 +3323,7 @@
     assert(first_accesses_.size());
     if (first_accesses_.back().tag == tag) {
         // If this layout transition is the the first write, add the additional ordering rules that guard the ILT
-        assert(first_accesses_.back().usage_index = SyncStageAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION);
+        assert(first_accesses_.back().usage_index == SyncStageAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION);
         first_write_layout_ordering_ = layout_ordering;
     }
 }