commit 8e599651c4145dfcee548f34ae0f6faf3e5d0512
author Jeremy Gebben <jeremyg@lunarg.com> Wed Oct 20 12:10:33 2021 -0600
committer jeremyg-lunarg <jeremyg@lunarg.com> Mon Oct 25 14:57:25 2021 -0600
tree 39ab8a23ea5e82353951a7805d8f136f90eee7ce
parent c7af14b7eb1862586e93b90cb789b1912704fb80

layers: Fix IMAGE_STATE::Unlink() for swapchain images

Since these images are only destroyed when the swapchain is
destroyed, calling RemoveParent on it is unnecessary and can
cause the parent_nodes_ set to be corrupted.

layers/image_state.cpp

diff --git a/layers/image_state.cpp b/layers/image_state.cpp
index ca525bb..5cb7311 100644
--- a/layers/image_state.cpp
+++ b/layers/image_state.cpp
@@ -545,9 +545,9 @@
 void SWAPCHAIN_NODE::Destroy() {
     for (auto &swapchain_image : images) {
         if (swapchain_image.image_state) {
+            RemoveParent(swapchain_image.image_state);
             swapchain_image.image_state->Destroy();
             dev_data->imageMap.erase(swapchain_image.image_state->image());
-            swapchain_image.image_state = nullptr;
         }
         // NOTE: We don't have access to dev_data->fake_memory.Free() here, but it is currently a no-op
     }