| commit | ac7e0cda633a58077684439111675e2d9460d5bf | [log] [tgz] |
|---|---|---|
| author | Derek Xu <derekx@google.com> | Fri Feb 10 19:02:20 2023 -0500 |
| committer | Derek Xu <derekx@google.com> | Sat Feb 11 13:48:38 2023 +0000 |
| tree | e2e0e8fe3ce90671cd826ffb2f85ef0d509e1fa7 | |
| parent | c08c9b2e7a61f98fb4e4f069ff7edd0f1b8cd4c3 [diff] |
Account for .exe executable suffixes on Windows It seems to me like proto_library.gni is missing some logic for handling adding .exe to plugin_path on Windows. Perfetto's proto_library template uses a _host_executable_suffix variable to handle this: https://android.googlesource.com/platform/external/perfetto/+/refs/heads/master/gn/standalone/proto_library.gni#71 I have added a similar variable in this change. I would like to add this behavior even though Fuchsia does not support building on Windows, because the Dart team would like to use protobuf-gn to build protos in the Dart SDK. See https://dart-review.googlesource.com/c/sdk/+/278942/17/runtime/vm/BUILD.gn#89 This change patches the only missing functionality for our needs. Ideally, this change can be applied to protobuf-gn, so we can avoid having to create our own fork. Change-Id: I7954c07c38ea5a8410bd7262074fdec7f0d611f1
This repository contains GN build system support for Protocol Buffers. It's in its own repository because it needs to be shared by Fuchsia and Cobalt.
This repo should be checked out such that:
//build/secondary/third_party/protobuf.//third_party/protobuf.//.gn contains secondary_source = "//build/secondary/"See the GN documentation on secondary_source.