commit | 0ce45f31826a65c6fe6cda5157bceb83d9b249a8 | [log] [tgz] |
---|---|---|
author | Oliver Newman <olivernewman@google.com> | Tue Feb 27 18:54:10 2024 +0000 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 27 18:54:10 2024 +0000 |
tree | dda997c5a3f9a3cf19d8118903c3e18a7299d94b | |
parent | 8504723daadcbdf595e8512b59743dc9b8ca5c6c [diff] |
[shac] Ignore changed files from different repos If the Gerrit change being tested is in a different repository from the repository being analyzed, don't consider any files affected. This ensures we don't incorrectly add comments to files in the wrong repository, which could happen if two repositories contained a file at the same location. I haven't seen any indication of this occurring yet, but it likely would have come up eventually. I also changed the `api.git.get_remotes()` function to return a list instead of a generator to make it behave less surprisingly when used in conjunction with `with api.context(cwd=...):`; when it returns a generator, the underlying step doesn't run until the generator is iterated over, which may be outside the intended context, as opposed to when the function is called. Change-Id: I0f5d622eb802589d4dd70863a1cd36e875b25005 Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/998512 Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> Reviewed-by: Ina Huh <ihuh@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython
and cipd
, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update
should download vpython
and cipd
into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/
. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython
and cipd
are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black .
in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json
to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }