tree dda997c5a3f9a3cf19d8118903c3e18a7299d94b
parent 8504723daadcbdf595e8512b59743dc9b8ca5c6c
author Oliver Newman <olivernewman@google.com> 1709060050 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> 1709060050 +0000

[shac] Ignore changed files from different repos

If the Gerrit change being tested is in a different repository from the
repository being analyzed, don't consider any files affected. This
ensures we don't incorrectly add comments to files in the wrong
repository, which could happen if two repositories contained a file at
the same location.

I haven't seen any indication of this occurring yet, but it likely would
have come up eventually.

I also changed the `api.git.get_remotes()` function to return a list
instead of a generator to make it behave less surprisingly when used in
conjunction with `with api.context(cwd=...):`; when it returns a
generator, the underlying step doesn't run until the generator is
iterated over, which may be outside the intended context, as opposed to
when the function is called.

Change-Id: I0f5d622eb802589d4dd70863a1cd36e875b25005
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/998512
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Reviewed-by: Ina Huh <ihuh@google.com>