commit 5d26b80e062a9cb6b8c5e332dc18b91e760af21b
author Taylor Cramer <cramertj@google.com> Thu Jan 10 17:07:25 2019 -0800
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Jan 11 17:41:11 2019 +0000
tree 2decb79c3ef1c9e1f4c3388fbc66b292ab2902e0
parent f5bf3ce0874e20154ceedc989b71e2f15ed4a908

[rust] Fix RwHandle failing to wake current task if CLOSED was already received

Test: ran mediasession tests before and after, only after were unstuck.
Unfortunately, a repeatable testcase for this would be extremely
difficult to craft as it is tightly coupled to the async runtime and
zircon port notifications.

Change-Id: I7e3fcf1aa278d61f721d1ebf0c3fe8783fd7f3c9

public/rust/fuchsia-async/src/rwhandle.rs

diff --git a/public/rust/fuchsia-async/src/rwhandle.rs b/public/rust/fuchsia-async/src/rwhandle.rs
index ee29a8f..60772fe 100644
--- a/public/rust/fuchsia-async/src/rwhandle.rs
+++ b/public/rust/fuchsia-async/src/rwhandle.rs
@@ -156,6 +156,10 @@
         if (old & READABLE) != 0 {
             self.schedule_packet(zx::Signals::OBJECT_READABLE)?;
         }
+        if (old & CLOSED) != 0 {
+            // We just missed a channel close-- go around again.
+            lw.wake();
+        }
         Ok(())
     }
 
@@ -172,6 +176,10 @@
         if (old & WRITABLE) != 0 {
             self.schedule_packet(zx::Signals::OBJECT_WRITABLE)?;
         }
+        if (old & CLOSED) != 0 {
+            // We just missed a channel close-- go around again.
+            lw.wake();
+        }
         Ok(())
     }