commit 4cf7208b0be85e72fc1b5f1c7918c91aceb4e889
author Dale Sather <dalesat@google.com> Mon Dec 10 11:32:26 2018 -0800
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Wed Dec 12 18:35:51 2018 +0000
tree 59074b50031fe07ea5d6b93822fe18c1a3233abd
parent 5a86f79843a297607b51815710c0ee30ec5faa8b

[mediaplayer] fix false expected condition in fake audio renderer

This CL fixes the fake audio renderer used for mediaplayer testing.
Previously, it would report success when packets were expected, the
packets that were actually delivered were as expected, but not all
expected packets were delivered.

TEST: this is test code
Change-Id: I4d0c56f2a4c4fa3b16ac8a9e3b59ac87a174296f

bin/mediaplayer/test/fakes/fake_audio_renderer.h

diff --git a/bin/mediaplayer/test/fakes/fake_audio_renderer.h b/bin/mediaplayer/test/fakes/fake_audio_renderer.h
index 08f86cb..ff6fed6 100644
--- a/bin/mediaplayer/test/fakes/fake_audio_renderer.h
+++ b/bin/mediaplayer/test/fakes/fake_audio_renderer.h
@@ -41,7 +41,11 @@
   }
 
   // Returns true if everything has gone as expected so far.
-  bool expected() { return expected_; }
+  bool expected() {
+    return expected_ &&
+           (expected_packets_info_.empty() ||
+            expected_packets_info_iter_ == expected_packets_info_.end());
+  }
 
   // AudioRenderer implementation.
   void SetPcmStreamType(fuchsia::media::AudioStreamType format) override;