commit 398b6583d6a23a0847a9c267580b7b7aebcbb30f
author Dale Sather <dalesat@google.com> Thu Dec 13 15:07:06 2018 -0800
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Dec 14 00:27:05 2018 +0000
tree 12356c00c3613fb1d1f3d94715f05adc4d28a591
parent 7a2d83f4c66a26e68b306e2fe2e8c86e524b677c

[mediaplayer] fix memory leak

This CL fixes a memory leak in mediaplayer caused by an incorrect
deleter for ffmpeg AVPacket structures.

TEST: tested using mediaplayer_test_util and ps

MTWN-166 #done

Change-Id: I978956d2529d2bacc14b1b9d897550769cafabae

bin/mediaplayer/ffmpeg/av_packet.h

diff --git a/bin/mediaplayer/ffmpeg/av_packet.h b/bin/mediaplayer/ffmpeg/av_packet.h
index 71d1bd5..8a93f14 100644
--- a/bin/mediaplayer/ffmpeg/av_packet.h
+++ b/bin/mediaplayer/ffmpeg/av_packet.h
@@ -14,16 +14,16 @@
 namespace ffmpeg {
 
 struct AVPacketDeleter {
-  inline void operator()(AVPacket* ptr) const { av_packet_unref(ptr); }
+  inline void operator()(AVPacket* ptr) const {
+    av_packet_free(&ptr);
+  }
 };
 
 using AvPacketPtr = std::unique_ptr<AVPacket, AVPacketDeleter>;
 
 struct AvPacket {
   static AvPacketPtr Create() {
-    AVPacket* av_packet = new AVPacket();
-    av_init_packet(av_packet);
-    return AvPacketPtr(av_packet);
+    return AvPacketPtr(av_packet_alloc());
   }
 };