blob: de9557ba5cd051809bb7173b3758cfe9d70b48d0 [file] [log] [blame] [view]
<!-- WARNING: This file is machine generated by //src/tests/fidl/source_compatibility/gen, do not edit. -->
Note: This document covers API impact only. For more details, see the
[ABI compatibility page](/docs/development/languages/fidl/guides/compatibility/README.md)
# Change a bits from flexible to strict
## Overview
-|[init](#init)|[step 1](#step-1)|[step 2](#step-2)|[step 3](#step-3)
---|---|---|---|---
fidl|[link](#fidl-init)||[link](#fidl-2)|
dart|[link](#dart-init)|||
go|[link](#go-init)|||
hlcpp|[link](#hlcpp-init)|[link](#hlcpp-1)||[link](#hlcpp-3)
llcpp|[link](#llcpp-init)|[link](#llcpp-1)||
rust|[link](#rust-init)|[link](#rust-1)||
## Initial State {#init}
### FIDL {#fidl-init}
```fidl
type Flags = flexible bits {
OPTION_A = 1;
OPTION_B = 2;
};
```
### Dart {#dart-init}
```dart
int useBits(fidllib.Flags bits) {
if (bits.hasUnknownBits()) {
return bits.getUnknownBits();
}
var result = fidllib.Flags.$none;
if ((bits & fidllib.Flags.optionA).$value != 0) {
result |= fidllib.Flags.$mask;
}
return result.$value;
}
```
### Go {#go-init}
```go
func useBits(bits lib.Flags) uint32 {
if bits.HasUnknownBits() {
return uint32(bits.GetUnknownBits())
}
var result lib.Flags = 0
if bits.HasBits(lib.FlagsOptionA) {
result |= lib.Flags_Mask
}
return uint32(result)
}
```
### HLCPP {#hlcpp-init}
```cpp
fidl_test::Flags use_bits(fidl_test::Flags bits) {
fidl_test::Flags result = bits | fidl_test::Flags::OPTION_A;
auto truncated = fidl_test::Flags::TruncatingUnknown(uint32_t(result));
ZX_ASSERT(!truncated.has_unknown_bits());
result &= fidl_test::Flags::kMask;
ZX_ASSERT(truncated == result);
return result;
}
```
### LLCPP {#llcpp-init}
```cpp
uint32_t use_bits(fidl_test::wire::Flags bits) {
auto result = fidl_test::wire::Flags::TruncatingUnknown(7u);
if (bits & fidl_test::wire::Flags::kOptionA) {
result |= fidl_test::wire::Flags::kMask;
printf("%d\n", uint32_t(result.unknown_bits()));
}
return uint32_t(result);
}
```
### Rust {#rust-init}
```rust
fn use_bits(bits: &fidl_lib::Flags) -> fidl_lib::Flags {
let mut result = fidl_lib::Flags::empty();
if bits.contains(fidl_lib::Flags::OptionA) {
result.set(fidl_lib::Flags::all(), true);
assert!(!result.has_unknown_bits());
}
return result;
}
```
## Update Source Code {#step-1}
### HLCPP {#hlcpp-1}
- Remove any usages of the bits mask member. This generated value is renamed for strict bits, so it must be temporarily hardcoded.
- Remove usages of flexible-only APIs
```diff
fidl_test::Flags use_bits(fidl_test::Flags bits) {
fidl_test::Flags result = bits | fidl_test::Flags::OPTION_A;
- auto truncated = fidl_test::Flags::TruncatingUnknown(uint32_t(result));
- ZX_ASSERT(!truncated.has_unknown_bits());
-
- result &= fidl_test::Flags::kMask;
- ZX_ASSERT(truncated == result);
+ fidl_test::Flags mask = fidl_test::Flags::OPTION_A | fidl_test::Flags::OPTION_B;
+ result &= mask;
return result;
}
```
### LLCPP {#llcpp-1}
- Remove usages of flexible-specific APIs
```diff
uint32_t use_bits(fidl_test::wire::Flags bits) {
auto result = fidl_test::wire::Flags::TruncatingUnknown(7u);
if (bits & fidl_test::wire::Flags::kOptionA) {
result |= fidl_test::wire::Flags::kMask;
- printf("%d\n", uint32_t(result.unknown_bits()));
}
return uint32_t(result);
}
```
### Rust {#rust-1}
- Remove usages of flexible-specific APIs
```diff
fn use_bits(bits: &fidl_lib::Flags) -> fidl_lib::Flags {
let mut result = fidl_lib::Flags::empty();
if bits.contains(fidl_lib::Flags::OptionA) {
result.set(fidl_lib::Flags::all(), true);
- assert!(!result.has_unknown_bits());
}
return result;
}
```
## Update FIDL Library {#step-2}
- Switch from `flexible` to `strict`
```diff
- type Flags = flexible bits {
+ type Flags = strict bits {
OPTION_A = 1;
OPTION_B = 2;
};
```
## Update Source Code {#step-3}
### HLCPP {#hlcpp-3}
- Use the renamed `FlagsMask` constant
```diff
fidl_test::Flags use_bits(fidl_test::Flags bits) {
fidl_test::Flags result = bits | fidl_test::Flags::OPTION_A;
- fidl_test::Flags mask = fidl_test::Flags::OPTION_A | fidl_test::Flags::OPTION_B;
- result &= mask;
+ result &= fidl_test::FlagsMask;
return result;
}
```