|author||RJ Ascani <firstname.lastname@example.org>||Fri Feb 19 22:05:30 2021 +0000|
|committer||releases-try-builder <email@example.com>||Fri Feb 19 22:33:20 2021 +0000|
[codec_impl] Send OnStreamFailed before OnFreeInputPacket It is largely expected for decrypting StreamProcessors to encounter a stream failure on the first decrypt packet, as keys may not be available yet. When this occurs, a OnStreamFailed event is sent and the stream must be restarted. In http://fxrev.dev/486344, a change was made to call OnFreeInputPacket for the packet that failed due to the lack of keys to signal the client that the packet is free. However, since those are independent events, there is no indication to the client that this packet failed. In some h264 streams, if that first packet is not retried, then the subsequent decoding attempt will fail as well. For that reason, it is temporarily preferable to have the client assume that any input packets and buffers currently with the StreamProcessor at the point of stream failure were unable to be completed. The OnFreeInputPacket events for those pending packets will be sent after the OnStreamFailed event so that the client knows that they are available for re-use. Bug: b/177173519, b/180649772 Change-Id: I7ae80bb6c11b2cd122d22b38606c8c5a342d64b8 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/486837 Reviewed-by: Dustin Green <firstname.lastname@example.org> Reviewed-by: Austin Foxley <email@example.com> Commit-Queue: RJ Ascani <firstname.lastname@example.org> API-Review: Dale Sather <email@example.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.