| commit | fab3d69f66401b2d2bd4cb005b90cf9a628e080a | [log] [tgz] |
|---|---|---|
| author | Aaron Drew <ripper@google.com> | Wed Jan 18 04:12:41 2023 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 18 04:12:41 2023 +0000 |
| tree | 837e3d61b1bfae9d449d5ba6f394ff9b0be16a5a | |
| parent | fd4936e366f9d5715201a3da12e55bf51e3ba50c [diff] |
[clippy] Fix potentially expensive `expect_fun_call` anti-pattern. This came out of a chat with josephry@. I noticed my teams code was calling format! during buffer deallocation and discovered a few hundred across the tree of this anti-pattern. Fixed with a manual edit to build/rust/clippy.gni followed by: ``` fx clippy --all --raw | fx shush --lint clippy::perf fix ``` Note that enforcement of this lint may require further discussion first so it is not part of this CL. Change-Id: Ia45b623684c86e2b3e543b33e178c5391b4f9e02 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/786893 Reviewed-by: Abdulla Kamar <abdulla@google.com> Commit-Queue: Aaron Drew <ripper@google.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.