commit f546709dbe76ba57f229912d8ce5533a6693c3d4
author Arthur Sfez <asfez@google.com> Mon Jul 26 17:37:28 2021 +0000
committer CQ Bot <commit-bot@chromium.org> Mon Jul 26 17:37:28 2021 +0000
tree 9d9a1186516bc9e0aa269632db68768e0ed2aabb
parent 2754b073172dd0e577674d24a2952f08e0c80420

[netstack] Add BaseSocket.Shutdown fidl method

The deprecated DatagramSocket.Shutdown fidl method is not used anywhere
anymore. This commit removes it. But until the next ABI transition, we
still need to keep the now deprecated BaseSocket.Shutdown2 method.

Remove the legacy test target where shutdown(2) implementation called
zx_socket_shutdown on the zircon socket, and instead add a new legacy
test target in which fdio uses the now deprecated Shutdown2 fidl method.

Now that no clients shutdown the zircon sockets themselves, the loopPoll
can be removed from netstack, because netstack calls shutdown on the
endpoint directly when the BaseSocket.Shutdown fidl method is called.

Note that this commit also fixes a dormant bug introduced in
commit a31257b11c3ff92523d776498541165ddc3d0160, where the
implementation of the fidl method Shutdown for StreamSocket would never
call Shutdown on the endpoint. It revealed itself when loopPoll was
removed.

Bug: 78129
Change-Id: I0c7193bcb0905121a08f03898c1c29f469c74f71
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/558885
Reviewed-by: Tamir Duberstein <tamird@google.com>
Reviewed-by: Roland McGrath <mcgrathr@google.com>
Commit-Queue: Arthur Sfez <asfez@google.com>
API-Review: Bruno Dal Bo <brunodalbo@google.com>