| commit | f051b946aa51f7d83a5fdbf7edf237e509d8c41d | [log] [tgz] |
|---|---|---|
| author | James Sullivan <jfsulliv@google.com> | Wed Mar 15 18:14:14 2023 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 15 18:14:14 2023 +0000 |
| tree | 0ebef3843d99926782601513487ca222716395ea | |
| parent | f246bfd6dae7e7f5335dabd73bbfe3e358704d54 [diff] |
[fatfs] Fix bug in determine_fs_geometry
The estimated FatType passed to determine_fs_geometry didn't match up
with the actual FatType used, which resulted in certain values failing
to find any valid geometries.
This change also makes determine_fs_geometry more strict about
respecting the requested FatType, which means that we have to change the
ffx efi plugin to *not* specify FatType since FAT32 has a minimum volume
size of 32MB. In practice, images smaller than this would have been
created in FAT12 or FAT16 format anyawys, so we might as well make this
explicit.
Tested: Added a regression test, and also tested all values in a large
range manually.
Change-Id: I4dd9c6d50d3d3af4938995104c6d3e0676d4bedf
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/819208
Reviewed-by: Stephen Demos <sdemos@google.com>
Commit-Queue: James Sullivan <jfsulliv@google.com>
Reviewed-by: Megan Batty <mgnb@google.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.