commit | ed6a77ef2eddf25ef685a21b3614654f342bce14 | [log] [tgz] |
---|---|---|
author | David 'Digit' Turner <digit@google.com> | Thu Mar 13 13:19:51 2025 -0700 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 13 13:19:51 2025 -0700 |
tree | 3cab2d0b1fb59d43402c6ed4d3322c7ba7f42760 | |
parent | 3dc5b0f1eec668be5b40b868580b1951c737d551 [diff] |
[bazel] workspace_utils.py: Fixed missing tracked files The generate_fuchsia_workspace() function returned a set of file paths that was missing a number of important input files that are read by the function. As a consequence modifying any of them would not properly trigger a regenerator invocation on the next `fx bazel` or `fx build` call: - build/bazel/templates/template.bazelrc - build/bazel/templates/template.bazel.sh - build/bazel/templates/template.platform.mapping This fixes the issue by: - Adding a `read_text_file()` function and `input_files` property to the GeneratedWorkspaceFiles class. - Using them to read input files in record_fuchsia_workspace() - Add the content of generated.input_files in the result of generate_fuchsia_workspace(). Manual comparison of the `build.ninja.d` file generated before and after the CL confirms that the missing input files are now properly listed in that file. Change-Id: Ifd05f1ba4802c6dd34367a5094d52f690b09d3dd Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1227466 Reviewed-by: Aaron Wood <aaronwood@google.com> Commit-Queue: David Turner <digit@google.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.