commit eb4bdf1c98dc42d022fcb27dcd9c023c9e6a320e
author Fady Samuel <fsamuel@google.com> Tue Jul 07 19:56:08 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jul 07 19:56:08 2020 +0000
tree b6d4aa20a6f4c26c446b98a98f5317ba2a0f43ea
parent 448b19ba397ccc2d556f1a393a114e49fc37d4d4

[components] Remove bad waiting API for tests.

wait_until_component_capability and wait_until_framework_capability
are test APIs that are all too easy to mess up and cause hours of grief.

The reason is that rely on an existing event stream that may receive
multiple event types. Receiving and processing those events may be
blocked on other event streams in the test's main task. If these APIs are also
used on the main task, then deadlock may occur. install_injector
solves this issue by creating a dedicated event stream for injection,
and runs the event stream in a separate task. The events to match on
are specified by an EventMatcher passed into install_injector.

Change-Id: I0445436fec26533611fbb42583a8bb49ab588ace
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404553
Reviewed-by: Justin Mattson <jmatt@google.com>
Reviewed-by: Shai Barack <shayba@google.com>
Reviewed-by: Bryan Henry <bryanhenry@google.com>
Testability-Review: Fady Samuel <fsamuel@google.com>
Commit-Queue: Fady Samuel <fsamuel@google.com>