commit ea4933a1c6d2e29a4f0a21ca4a073e3cc748b601
author Benjamin Lerman <qsr@google.com> Tue Jun 18 07:39:13 2019 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jun 18 07:39:13 2019 +0000
tree c74c9e7bfa7ba749add51e59bfd73e45b71f552c
parent b2ef9fd393ef24daa4ae5474592ec964fb8c8712

Revert "[components] Add Components v2's component_manager to the running system"

This reverts commit 7b40f79df1115611c01ba2fd5e100d6328d51e56.

Reason for revert: Change break the fx workflow.

Running: 'fx set workstation.x64 --with=//topaz/packages:all,//garnet/packages:all,//peridot/packages:all' fails with:
FAILED: build.ninja 
../../buildtools/linux-x64/gn --root=../.. -q --check, --export-compile-commands gen .
ERROR at //products/workstation.gni:25:1: Replacing nonempty list.
kernel_cmdline_args = [
^------------------
This overwrites a previously-defined nonempty list with another nonempty list.
See //products/bringup.gni:12:23: for previous definition
kernel_cmdline_args = [ "bootsvc.next=bin/component_manager,fuchsia-boot:///boot#meta/root.cm,--use-builtin-process-launcher" ]
                      ^-------------------------------------------------------------------------------------------------------
Did you mean to append/modify instead? If you really want to overwrite, do:
  foo = []
before reassigning.
See build arg file (use "gn args <out_dir>" to edit):1:1: whence it was imported.
import("//products/workstation.gni")
^----------------------------------


Original change's description:
> [components] Add Components v2's component_manager to the running system
> 
> Makes devcoordinator a v2 Component. Start component_manager from
> bootsvc rather than devcoordinator, with devcoordinator being the first
> (and only) component loaded during boot (for now).
> 
> This only currently affects builds produced from one of the Fuchsia
> product configurations, not standalone Zircon builds, pending completion
> of BLD-382. When BLD-382 is complete we will update the default
> 'bootsvc.next' in bootsvc.
> 
> CF-659 #comment
> BLD-382 #comment
> 
> Test: Tested by existing CQ/CI bots; failures would most likely manifest
> as a boot failure, which would be loud and obvious.
> Test: Passed GI and Astro E2E test dry-run.
> 
> Change-Id: I2cc7e64a8fa4e2899f4dc685161412c945aeb52f

TBR=jamesr@google.com,jeffbrown@google.com,geb@google.com,shayba@google.com,dgonyeo@google.com,bryanhenry@google.com

Change-Id: Ie0028de72e3611610cd0a3b50875bf89f0d65640
No-Presubmit: true
No-Tree-Checks: true
No-Try: true