| commit | e2dfc247862ff085757290f3ac5ef8d138b1dade | [log] [tgz] |
|---|---|---|
| author | Scott Graham <scottmg@google.com> | Tue Jul 07 19:47:56 2020 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jul 07 19:47:56 2020 +0000 |
| tree | b2b6e0b5e334087c1a8f067d062a8701b63766f2 | |
| parent | 15eb88437911025b11d8d30f7f9e53c63336b27d [diff] |
[check-system] Make //src/media/codec/examples/use_media_decoder check-system clean
ERROR at //src/media/codec/examples/use_media_decoder/use_aac_decoder.cc:9:11: Can't include this header from here.
#include <lib/media/test/codec_buffer.h>
^----------------------------
The target:
//src/media/codec/examples/use_media_decoder:use_media_decoder_source_set
is including a file from the target:
//src/media/lib/test:codec_buffer
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//src/media/codec/examples/use_media_decoder:use_media_decoder_source_set -->
//src/media/lib/test:codec_client --[private]-->
//src/media/lib/test:codec_buffer
Bug: 55166
Change-Id: Ief0d5c95a0ac63d463470b5119e207b312f5c350
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404672
Commit-Queue: Scott Graham <scottmg@google.com>
Reviewed-by: Shai Barack <shayba@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See fuchsia.dev.