commit e2bc7edc6d1498baeaeef7d646807f59eda3683f
author Rich Kadel <richkadel@google.com> Thu Jan 19 04:36:06 2023 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 19 04:36:06 2023 +0000
tree 9bfb9e81f84a5251a8c44bc7648af2a9f798e22d
parent c8f35d87ff44a6da99b9003415b7260282f9c192

[assembly] no anonymous entries for named base packages

Developers are working around scrutiny issues with the
`_do_not_use_<merkle>` entries by adding anonymous subpackages to the
named base packages list, to avoid creating anonymous subpackages.

(See this workaround, described in the "Bug:" below.)

But the current algorithm to produce the `static_packages` file does not
actually guarantee that a named package will not also appear as an
anonymous `_do_not_use_<merkle>` entry. Depending on the order base
packages and subpackages are added, the `static_packages` file can
include duplicate entries for the same package hash, one as a named
package and one as an anonymous subpackage.

This CL addresses that problem.

Bug: 117847
Change-Id: I7daf656b065fbe788c5853b19b4bd833542c32d3
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/791063
Fuchsia-Auto-Submit: Rich Kadel <richkadel@google.com>
Reviewed-by: Aaron Wood <aaronwood@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>