commit e2925c94a8c92721fd75dcb9c355fe016aaff93e
author Mark Seaborn <mseaborn@google.com> Tue Jul 07 20:41:57 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jul 07 20:41:57 2020 +0000
tree d21c1a8a8cc6742693ca9b68b37417ff60d11fef
parent c8daff2c794ba30681d15dea5ef70c8ea06df68c

[utest][threads] Finish conversion of tests to using zxtest instead of unittest

threads.cc had already been converted to using zxtest but
register-set.cc still used unittest.  That is actually risky, because
without an explicit main() function it is not well-defined whether
unittest's main() or zxtest's main() will get linked.

This was mostly automated, with some manual changes:

 * change helper functions: return void not bool; calls use
   ASSERT_NO_FATAL_FAILURES()
 * change EXPECT_EQ() calls where printf format string literals are
   required: merge the snprintf()s into the EXPECT_EQ() calls
 * ensure zxtest is not listed twice in the BUILD.gn file

Bug: 51652
Test: runs on CQ, but tested locally with:
  fx set bringup.x64 --with-base //garnet/packages/tests:zircon --with-base //bundles/bringup:tests
  fx build
  fx qemu -k -c zircon.autorun.boot=/boot/test/core-threads
Change-Id: Ie30dcbd10ef59b6e02161ec63fd5b7457c368165
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404811
Reviewed-by: Scott Graham <scottmg@google.com>
Reviewed-by: George Kulakowski <kulakowski@google.com>
Testability-Review: George Kulakowski <kulakowski@google.com>
Commit-Queue: Mark Seaborn <mseaborn@google.com>