| commit | b4a64b05fe58310aad29e5b493fb6c33aaf7ad6d | [log] [tgz] |
|---|---|---|
| author | John Grossman <johngro@google.com> | Sat Nov 16 06:42:02 2024 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Nov 16 06:42:02 2024 +0000 |
| tree | 77fa5b833e8607e2e84419a48ec19263d5fc296c | |
| parent | 0e10305ddb1c330919b34345f0c38aee976d475e [diff] |
[fbl][canary] Print the observed value during a panic. Print the observed value of the magic number when a fbl::Canary fails an ASSERT predicate, instead of allowing the code to re-load the magic number post-predicate failure for panic printing purposes. In a perfect world, this should never (ever) matter. That said, when your Canary assert predicates are firing, the world is a long way from being perfect, and it can actually be important that we report the exact value used in the predicate evaluation in order to help understand what might have went wrong. See the attached bug for a practical example. Bug: 313083326 Change-Id: Ic70d393def2e97a79a63ba8b9af7f2b9436dbb4f Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1158041 Fuchsia-Auto-Submit: John Grossman <johngro@google.com> Reviewed-by: Roland McGrath <mcgrathr@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.