| commit | b48c3c11e7449ec82b9ca28a5c2b321df95129bf | [log] [tgz] |
|---|---|---|
| author | Mitchell Kember <mkember@google.com> | Mon Apr 05 17:39:52 2021 +0000 |
| committer | CQ Bot <commit-bot@chromium.org> | Mon Apr 05 17:39:52 2021 +0000 |
| tree | 4550209f17106c13fd2b8dda263420fadc18e825 | |
| parent | 0d2b05ed27445cb7bfc1a919f55fb83e89f9f175 [diff] |
[golden-util] Add tests, and other improvements This CL adds unit tests to golden-util. Thinking through the correct behavior for tests led to some changes, so this CL also: * Makes test mode fail if there are extra files in goldens.txt that are no longer generated (which regen will remove). It used to succeed, meaning you could remove a golden_test entry and forget to regen, leading to a confusing unrelated change in the next CL that regens. * Disallows golden subdirectories. This has been enforced since I75e36ed0cfba13a1f12f75a3ea41e1418f2becf4 by golden_test.gni because we didn't need it, and doing so greatly simplified path manipulations. This CL removes the unused functionality from golden-util. * Tightens manifest validation (check for missing JSON fields, check for duplicates among the generated paths) and adds goldens.txt validation. * Replaces uses of ioutil (see https://golang.org/doc/go1.16#ioutil). Test: fx test golden_util_tests Change-Id: I6eeb0c7f581b9663e12bcc784045b583086cc0a1 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/511058 Commit-Queue: Mitchell Kember <mkember@google.com> Reviewed-by: Pascal Perez <pascallouis@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.