commit | ae08444bcdf05acc2503b8d108fe15ebb5a19f3e | [log] [tgz] |
---|---|---|
author | Ina Huh <ihuh@google.com> | Fri Jun 24 22:58:02 2022 +0000 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 24 22:58:02 2022 +0000 |
tree | b06a5f372f9a8f91eb0ea7c15858ef161313a152 | |
parent | c5230c0517e5662d46d39c1cd49e8fc4c79aa30d [diff] |
Reland "[sl4f][evolution] Add audio test FIDL protocol" This reverts commit 036c8d65a081a04a10c8c26c519537570c6be339. Reason for revert: it was not the cause of the failures Original change's description: > Revert "[sl4f][evolution] Add audio test FIDL protocol" > > This reverts commit 87eadfccb4d145e8e1faf9d922e59ef8c0a8ab31. > > Reason for revert: flakes in knowledge_card_test > Bug: 103329 > > Original change's description: > > [sl4f][evolution] Add audio test FIDL protocol > > > > - Convert audio facade implementation into a test component under > > sl4f.core_shard > > - Note I've merged sl4f/src/audio/facade.rs into commands.rs in order > > for Gerrit to show the diff between the then facade.rs and the new > > sl4f/audio_recording/src/lib.rs > > - sl4f audio facade now calls the AudioRecordingControl protocol. > > - Added a clear_input_audio method to clear injected audio file. This > > used to be done automatically in put_input_audio, but due to input > > size, we need to allow put_input_audio to only append. I chose to > > use `vector<uint8>:AUDIO_INPUT_BYTES_MAX` as input arg for > > `PutInputAudio` so that we can create a ffx plugin that injects > > audio. > > - [fix] Updated setui facade to handle where mic is not present (i.e > > FEMU). This allows e2e tests to pass on emulator. > > > > Bug: 101853 > > Change-Id: Ie5e8ea3a4c3ed047d5a3f5643a67b8d11978bfdd > > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/686111 > > Reviewed-by: Tom Bergan <tombergan@google.com> > > Reviewed-by: Miguel Flores <miguelfrde@google.com> > > API-Review: Dale Sather <dalesat@google.com> > > Commit-Queue: Yuan Zhi <yuanzhi@google.com> > > Bug: 101853 > Change-Id: If8b849d1dd8372de7566d9b04c8e26ef2ad842de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/693919 > Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com> > Commit-Queue: Ina Huh <ihuh@google.com> Bug: 103329 Bug: 101853 Change-Id: I40546000d043bb7dbbc6efb26c91e860500e3141 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/694242 Commit-Queue: Ina Huh <ihuh@google.com> Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.