| commit | 8662ac21d9709df54805ee27b96d5150fe8f6352 | [log] [tgz] |
|---|---|---|
| author | global-integration-roller <global-integration-roller@fuchsia-infra.iam.gserviceaccount.com> | Mon Sep 16 17:37:03 2024 +0000 |
| committer | GI Roller <global-integration-roller@fuchsia-infra.iam.gserviceaccount.com> | Mon Sep 16 17:37:03 2024 +0000 |
| tree | 42caa5be93b6ba6b17cd6bcb7f7cb4d2187b1156 | |
| parent | 4425913e7d2eafdd2be69bc28773d0a028410189 [diff] |
[superproject] Roll third_party/pigweed pw_spi_linux: Avoid unneccessary ioctl()s in Configure()
Initiator::Configure() is called on every Device::WriteRead() call, in
case different devices on the bus use different configuration.
Avoid unnecessary ioctl() calls by recording the current configuration
and skipping Configure() if the new config is not actually different.
If the pw::spi::Initiator base class were using the non-virtual
interface (NVI) pattern, this could be implemented there and apply to
all initiator implementations.
Test: Verified downstream project still works and redundant ioctls no
longer happen
Original-Bug: 366541694
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/235877
Original-Revision: eefd313bdb13098552cd713598b937debe80d3d4
GitOrigin-RevId: 329064affb10f2bcf9b02830ad027847de6ff386
Roller-URL: https://ci.chromium.org/b/8736618744559677745
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I37afe3c6be5f716b011a6f6edb57e4bc9d879d99
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1119753
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.