commit 7b4123d473650eb45fe1c31604b9fbd5d95a740b
author Scott Graham <scottmg@google.com> Tue Jul 07 20:28:14 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jul 07 20:28:14 2020 +0000
tree 1a962b5cf61c887033cfb3333ce49a58d7ccc583
parent 164e01cecacc8a5af2f82e89486369f4bf4ac9aa

[check-system] Make src/modular/bin/basemgr_launcher check-system clean

    ERROR at //src/modular/bin/basemgr_launcher/main.cc:21:11: Can't include this header from here.
    #include <src/lib/fxl/command_line.h>
              ^-------------------------
    The target:
      //src/modular/bin/basemgr_launcher:basemgr_launcher_bin
    is including a file from the target:
      //src/lib/fxl:fxl

    It's usually best to depend directly on the destination target.
    In some cases, the destination target is considered a subcomponent
    of an intermediate target. In this case, the intermediate target
    should depend publicly on the destination to forward the ability
    to include headers.

    Dependency chain (there may also be others):
      //src/modular/bin/basemgr_launcher:basemgr_launcher_bin -->
      //src/modular/lib/modular_config:modular_config --[private]-->
      //garnet/public/lib/json:json -->
      //src/lib/json_parser:json_parser -->
      //src/lib/fxl:fxl

Bug: 55166
Change-Id: I0a243491ea93cc0408475ce973d00e9e8c61d265
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404717
Commit-Queue: Scott Graham <scottmg@google.com>
Reviewed-by: Przemek Pietrzkiewicz <ppi@google.com>