commit 74adaf12a566fe5e885db4557648256873339cf9
author Filip Filmar <fmil@google.com> Tue May 05 02:38:32 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue May 05 02:38:32 2020 +0000
tree 8b99a7ca57b702ff90d62926ffaa23be4bb904f4
parent eb0d32cb413ad48b73241dd46eac856f8077ba26

[intl] Tightens the string naming controls

In an early field test, lucasradaelli@ discovered that `strings_to_fidl`
let an identifier name such as "role_table," go through. Notice the
extra unwanted comma at the end.

While `strings_to_fidl` doesn't really have a preference, the FIDL file
that is generated based on strings.xml ends up with unallowed syntax.

So, we tighten the behavior to fail fast instead of generating a FIDL
file that won't pass a followup FIDL compilation step.

Example error given below:

```
╰─>$ ./strings_to_fidl --input=$HOME/strings.xml --output=$HOME/strings.xml.out ; cat $HOME/strings.xml.out
Error: while parsing dictionary

Caused by:
    0: in state: String { name: "string_name,", text: "text_string" }
    1: name is not acceptable: 'string_name,', does not match: ^[_a-zA-Z][_a-zA-Z_0-9]*$
```

Bug: 50720
Change-Id: Id178b3c4af434803ced1251a284c2a43947937c8
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/385229
Commit-Queue: Filip Filmar <fmil@google.com>
Reviewed-by: Konstantin Pozin <kpozin@google.com>
Testability-Review: Filip Filmar <fmil@google.com>