commit 6e0654f180ff355a85cb49174f104601dc75d1fb
author Marc-Antoine Ruel <maruel@google.com> Wed Jul 08 22:32:27 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Wed Jul 08 22:32:27 2020 +0000
tree 33d81501ab56953a143ce6b5d65d1c63fe9d3acc
parent dfab9d25ace1f6cc317ffb80a41a4a8c5d42bced

[go] Enable declaration of recursive package in GN

This change is effectively a no-op from a build perspective. It adds a
'/...' suffix to some package definitions in GN and change build/go/build.py to
tolerate these.

The '/...' Go package suffix is a well known and documented format in Go to
declare recursivity.

The end goal is to change the go package naming convention:
- A GN Go package ending with '/...' means that the package includes all
  children packages.
- A GN Go package without this suffix means that no children packages is
  included.

The status quo at the moment is that all children Go packages are included.

This causes all sorts of issues and surprises. This caused the proliferation of
"lib" pseudo-packages under //tools and the anti-pattern of the relative
directory not matching the relative Go package name.

Switching the logic requires updating a lot of packages so this will be
done over the course for several CLs.

All third_parties are effectively used as recursive dependencies so
update third_party/golibs/BUILD.gn right away, to show how it'll look
like in the end state for recursive packages.

Bug: 55387
Change-Id: Ib25e65230594d5c0469642a2e36f266499a9c85a
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404216
Commit-Queue: Marc-Antoine Ruel <maruel@google.com>
Reviewed-by: Shai Barack <shayba@google.com>
Reviewed-by: Petr Hosek <phosek@google.com>
Testability-Review: Shai Barack <shayba@google.com>