| commit | 5ff9ef379311b9edc7a21b641e5044f2309a3113 | [log] [tgz] |
|---|---|---|
| author | Robert Quattlebaum <rquattle@google.com> | Tue Jul 07 22:35:17 2020 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jul 07 22:35:17 2020 +0000 |
| tree | b471f39645e48ba40c2aa6a8e8e9272e36f3befb | |
| parent | 5803d1c121b113aa53f17daadc5f529368799a39 [diff] |
[lowpan][lowpan-spinel-driver] Reset the send window before calling open. This change fixes a race condition in `SpinelDeviceSink::open` that could cause the send window to be reset after the Spinel device had already (re)opened and sent us a `OnReadyForSendFrames`. This would cause the send window to remain at zero, resulting in no frames being able to be sent to the device. Aside from correcting what is a clear logic error, writing a unit test for this change that would have failed previously but will now succeed is tricky. The issue was discovered when testing on real hardware, and manual verification indicates that this change does address the problem. Existing tests continue to pass. Test: fx test lowpan-tests Change-Id: I933c7ba50f29357ac7b83a155e941ab8ff246a4b Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/401679 Commit-Queue: Robert Quattlebaum <rquattle@google.com> Testability-Review: Jiaming (Charlie) Wang <jiamingw@google.com> Reviewed-by: Jiaming (Charlie) Wang <jiamingw@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See fuchsia.dev.