commit 5c8f13a86b955315b3d79a68255c3b4fc2936607
author Charles Celerier <chcl@google.com> Thu Jan 30 12:36:06 2025 -0800
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 30 12:36:06 2025 -0800
tree 52c3bf16934f3ed26785b42ff79b932957b41d7b
parent cfe454188ad51b990d251098b724fd0d3aaeafb4

[sdk] Only include RTC conformance test on Linux host builds

The mac SDK will no longer contain
//src/tests/end_to_end/rtc:rtc_conformance_test_sdk which itself
contains a Lacewing test. In general, Lacewing tests are only designed
to run on Linux hosts, so we should not build them for mac.

This change contains a horrendous hack. While constructing this change,
I found that a mac builder would fail when I removed
//src/tests/end_to_end/rtc:rtc_conformance_test_sdk from the build
graph. After some debugging, it appeared that removing that target
caused //src/developer/ffx/frontends/ffx:ffx_bin_unversioned to be built
in parallel with various ffx tool metadata targets leading to a failure
to read system domain SSL certificates from the host. The hack is to
add a dependency from each metadata target to ffx_bin_unversioned to
ensure ffx_bin_unversioned is built before them. For a currently unknown
reason, this steps around the mac builder failure.

If this change lands successfully, then we know we've fixed
https://fxbug.dev/388826354 because otherwise we would expect the mac
builder failure to continue to reproduce. It's really
https://fxrev.dev/1195919 that fixes the issue though.

Fixed: 388826354
Change-Id: I10429267e2875c3ccc71ed8329d08ebaa48ff2a4
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1192733
Reviewed-by: Andrew Davies <awdavies@google.com>
Fuchsia-Auto-Submit: Charles Celerier <chcl@google.com>
Reviewed-by: Aaron Wood <aaronwood@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>