| commit | 5be3060c524b5ce9ca9d3687ef631efb285cb5b6 | [log] [tgz] |
|---|---|---|
| author | Chris Drouillard <cdrllrd@google.com> | Mon Feb 10 16:55:31 2025 -0800 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 10 16:55:31 2025 -0800 |
| tree | 79c046ec2553d99784ae4387e735c5133fc586b4 | |
| parent | 24d440a7de78cc1af1640f021ee7f4242ed3cbeb [diff] |
[fxfs] Box Item in async code Item<ObjectKey, ObjectValue> is 224 bytes. Every time an Item is passed to an async fn or held across an await, the future needs to capture the Item and the future grows by 224 bytes. The MergerIterator::advance_impl future is 1584 bytes because it holds 6 Items. Boxing Item here reduces the size of the MergerIterator::advance_impl future to 312 bytes. Bug: b/393365596 Change-Id: I08cd5542fccea472c8bd752e828679ff7bf2b38e Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1198689 Reviewed-by: James Sullivan <jfsulliv@google.com> Commit-Queue: Chris Drouillard <cdrllrd@google.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.