| commit | ad9b16ecd565e2e7c58961769af70efa89230a11 | [log] [tgz] |
|---|---|---|
| author | Josh Gargus <jjosh@google.com> | Sat May 25 03:56:28 2019 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Sat May 25 03:56:28 2019 +0000 |
| tree | 0cd1ec59950492d0878a4ee8f51aa8b6422a8f8d | |
| parent | 6322fd7d221f5793f6b0dd6abf96b55e603b5a8d [diff] |
[escher][SCN-1444] Wait for mesh uploads to complete. This fixes an issue where a "render command buffer" was not waiting for a "transfer command buffer" to complete because not all of the semaphores were waited-upon. This was due to inherent finickiness of Mesh inheriting from WaitableResource; it was easy to become confused about whether to take the semaphores from the Mesh or from the Buffers that it encapsulates. After this CL, Mesh no longer inherits from WaitableResource, making this confusion impossible. Testing: in addition to the usual tests, added a new test to paper_shape_cache_unittests.cc which would have detected this issue. ES-104 #comment ES-206 #comment SCN-1444 #done Change-Id: I3bc4032aff593c1568c527d2ee3ac5729345b74b
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See the documentation.