| commit | 555057f8e5725964cfca91954c90918450fa60b2 | [log] [tgz] |
|---|---|---|
| author | Stephen Demos <sdemos@google.com> | Fri Nov 13 00:25:48 2020 +0000 |
| committer | CQ Bot <commit-bot@chromium.org> | Fri Nov 13 00:25:48 2020 +0000 |
| tree | 47fd62879e321e9970009c852354d45df433e886 | |
| parent | 872b7f075ffe270598054c81b4f2cb94798c6943 [diff] |
[ulib/fs] wait for remote to close on error During remote mounting, the host filesystem essentially takes ownership of the remote filesystem, and similar to channel ownership, it is responsible for tearing down the remote filesystem when an error occurs. This tear down on error was asynchronous - it wouldn't wait for a response before finishing the request. This would cause tests to occationally flake if they tore down the test environment before the async filesystem shutdown finished. This change makes Mount and MountAndCreate block on the shut down of the remote filesystem. Before this change, `fx test fs-management-test -- -f MountFailsWithoutAdminCase.MountFailsWithoutAdmin` would fail every few hundred times on qemu, with this change it's gone for about 10k without a failure. Bug: 61269 Test: fx test fs-management-test Change-Id: I1b5471061d9affafe8f055e172e17a46bb21d3e6 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/450294 Reviewed-by: Chris Suter <csuter@google.com> Testability-Review: Chris Suter <csuter@google.com> Commit-Queue: Stephen Demos <sdemos@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.