| commit | 472ba58b05305d40d85fd715591bcf31e4a0f051 | [log] [tgz] |
|---|---|---|
| author | Jody Sankey <jsankey@google.com> | Mon Apr 18 19:54:19 2022 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 18 19:54:19 2022 +0000 |
| tree | 283fc511451c66de270fb736c048482ef31e76a8 | |
| parent | f6a01f36659101169d7e0e1a798099aebc434556 [diff] |
[CredMgr] Refactor inspect topology
This does a few things to make the structure a bit more scalable:
* The IncomingMethod enum is now constructed with a pro macro that lets
inspect iterate over its values so we can pre-polutate nodes for each
RPC and also retain more of the convention of snake_case inspect
(thank you paste!{})
* We nest the actual error counts and include a summary count of the
errors which makes it easier to write a traige rule to detect errors
* All the incoming RPC are nested under an "incoming" node to provide
room for other types of output.
Looking at the inspect unittests is the easiest way to visualize the new
output.
Note being able to refactor inspect output like this without having to
change operational code or tests shows the benefit of isolating with the
diagnostics trait.
Bug: 91714
Change-Id: I1c6a3c752578edd04cc97eb5d21950089d7fd2a0
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/669166
Reviewed-by: Ben Wright <benwright@google.com>
Commit-Queue: Jody Sankey <jsankey@google.com>
Fuchsia is an open source, general purpose operating system supporting modern 64-bit Intel and ARM processors.
We expect everyone interacting with our project to respect our code of conduct.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.