commit 1e486c4254e0b3f980b1329386429c037e585fb5
author Joshua Seaton <joshuaseaton@google.com> Tue Jul 27 00:55:13 2021 +0000
committer CQ Bot <commit-bot@chromium.org> Tue Jul 27 00:55:13 2021 +0000
tree 4b33976093d300c8c9cfc5c129f6008306c73974
parent 56180e7fb11b0a0769a92db81af0aae494fae929

Revert "[zbitl] Add mutability-related container traits"

This reverts commit f855d59a4c76c689ce07e2926b3747adfd0a2bf3.

Reason for revert: This was a misstep

Original change's description:
> [zbitl] Add mutability-related container traits
>
> We add the following container traits:
> ```
> /// Whether the container's contents are permitted to be mutated.
> static constexpr bool kIsMutable = false;
>
> /// Updates the size of the associated payload. It is the responsibility
> /// of the caller to ensure that this size is sensible; no check is
> /// performed. This trait is only required if `kIsMutable` is true.
> template <typename = std::enable_if<kIsMutable>>
> static void SetPayloadSize(item_header_type& header, uint32_t new_size);
>
> /// Modify a header so that it passes checks. This can be used to mint
> /// new items from a designated initializer that omits uninteresting
> /// bits. This trait is only required if `kIsMutable` is true.
> template <typename = std::enable_if<kIsMutable>>
> static item_header_type SanitizeHeader(item_header_type header);
> ```
> Though only relevant to the ZBI case, introducing these traits will
> allow us to more cleanly layer zbitl::View atop a
> zbitl::internal::Container.
>
> Bug: 68585
> Change-Id: Ief4f180db1a49904b3e35032e341bffe9bcfd364
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/523125
> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
> Reviewed-by: Joshua Seaton <joshuaseaton@google.com>
> Reviewed-by: Roland McGrath <mcgrathr@google.com>
> Fuchsia-Auto-Submit: Joshua Seaton <joshuaseaton@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 68585
Change-Id: I506758635e600dedf3681c680241935c551c73a8
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/560380
Reviewed-by: Joshua Seaton <joshuaseaton@google.com>
Commit-Queue: Joshua Seaton <joshuaseaton@google.com>
Fuchsia-Auto-Submit: Joshua Seaton <joshuaseaton@google.com>