| commit | 7db888a081ced168c3e0df71a012e2b6ac7df634 | [log] [tgz] |
|---|---|---|
| author | Felix Zhu <fcz@google.com> | Tue Jul 27 14:37:02 2021 +0000 |
| committer | CQ Bot <commit-bot@chromium.org> | Tue Jul 27 14:37:02 2021 +0000 |
| tree | ceaa3db08d647457f7b9ef42bda2c72f2d29dbdc | |
| parent | cde23b42767346d4160417cf520298da45614ec9 [diff] |
[fidl-lint] Remove repeater checks Repeater checks attempt to enforce the aspect of the FIDL style guide that says to avoid repeating a component from the parent context's name (unless it serves to disambiguate). This check has never been enabled due to false positives - given the amount of time this feature has existed but not been touched, we opt to remove this feature rather than continue maintaining it (for example, updating it to support anonymous layouts). This is done by simplifying the context stack from a deque<Context> into a stack<string> representing the layout kinds (the deque -> stack is an independent change to improve readability). Test: fx ninja -C out/default host_x64/fidl-compiler && ./out/default/host_x64/fidl-compiler --gtest_filter='LintFindingsTests.*' Change-Id: I26d5c869e5484b0928e7306bcba58b17febadeb4 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/560443 Reviewed-by: Ian McKellar <ianloic@google.com> Commit-Queue: Felix Zhu <fcz@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.