| commit | 2b70405cd02d07dade89a1cb0fb53c4c73104516 | [log] [tgz] |
|---|---|---|
| author | Scott Graham <scottmg@google.com> | Mon Feb 11 16:21:38 2019 -0800 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Feb 12 03:32:52 2019 +0000 |
| tree | 2fe80a622967028bedcc18e116e45da87e8d93d0 | |
| parent | 708edd9fd20bea4033a44702a13e6a04af611a1e [diff] |
[gn][fs-host] Satisfy TA_GUARDED in FileSizeRecorder
Pending host gn build enables more warnings, and it doesn't like null
checks or OpenFileSize() without holding the guard.
[8874->872/9803 ~58] CXX host-x64-linux-clang/obj/system/ulib/fs-host/libfs-host.file_size_recorder.cpp.o
../system/ulib/fs-host/file_size_recorder.cpp:15:9: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis]
if (sizes_file_)
^
../system/ulib/fs-host/file_size_recorder.cpp:17:5: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis]
sizes_file_.reset(open(path, O_CREAT|O_TRUNC|O_WRONLY, 0644));
^
../system/ulib/fs-host/file_size_recorder.cpp:18:17: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis]
return bool{sizes_file_};
^
../system/ulib/fs-host/file_size_recorder.cpp:22:8: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis]
if (!sizes_file_) {
^
4 warnings generated.
ZX-3415 #comment [gn][fs-host] Satisfy TA_GUARDED in FileSizeRecorder
Test: CQ
Change-Id: I1bd7ad4c17acfc7dd6947e52ea895c0fa2d3a31b
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See the documentation.