commit 1f1fd5228ba3a2f719fd83b743c0764a2f57b2b7
author Andrew Davies <awdavies@google.com> Thu Aug 22 00:54:13 2024 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 22 00:54:13 2024 +0000
tree 6079198c7e0161790e97aaf16ae17f030debb6b3
parent c3a23d1a01e244ae12b8136ba5e1366cd151d5f5

[ffx] Move SSH error checks to frontend. Report to user.

This takes ssh errors encountered when attempting to get a remote
control proxy and sends them to the user. Previously these errors would
be logged to the daemon log and then removed, not giving clients the
insight into what may be hanging.

Now, the error is always reported to the user, with reattempts happening
the same as before, but just on the client side. If a deemed-non-fatal
error is encountered, at which point a reconnect attempt will happen,
the error is printed for the user to see.

There are three considered-fatal SSH errors: key verification failure,
permission denied, and invalid arguments. These are all errors that
cannot be fixed no matter how many reattempts occur.

Bug: 357958365
Change-Id: Ie9adf90440a547333802ec704fa6be72501dd2c9
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1101154
Reviewed-by: Colin Nelson <colnnelson@google.com>
Commit-Queue: Andrew Davies <awdavies@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Reviewed-by: Darren Chan <chandarren@google.com>