commit 1efd2a96079e2ec0d8ff57bf9e743ba6e1be44e6
author Oliver Newman <olivernewman@google.com> Wed Nov 11 13:55:25 2020 +0000
committer CQ Bot <commit-bot@chromium.org> Wed Nov 11 13:55:25 2020 +0000
tree 62686b3db9fa24f48f511759c81ffed6f285753d
parent 2bca55efa88b2f31d691415a31dba20dc6f32eb7

Revert "[size_checker] Formats ICU data nodes nicely"

This reverts commit fe37c1ffee1b0a043a786c9357f226860a9bc4cc.

Reason for revert: size_checker_tests is hard-failing: https://luci-milo.appspot.com/p/fuchsia/builders/try/fuchsia-x64-asan/b8863924716378095104

Original change's description:
> [size_checker] Formats ICU data nodes nicely
>
> The old code used the generic display, which was confusing since it
> printed information that is irrelevant for the ICU data nodes.
>
> Here is the new display.  The relevant bits for diagnosis and debugging
> are:
>
>   - the total size of the data
>   - the distinct blob IDs used by icudtl.dat files
>   - the number of distinct reuses
>   - what are the packages or sources of reach reuse, formatted without
>     extra visual clutter.
>
> ```
> ICU Data                                 |   8.75 MiB |   9.50 MiB |   0.75 MiB
>   icudtl.dat: 8.75 MiB from 2 copies
>     Blob ID 295c8ef47e823fda756f3d176799b6b19e9620bef3d204cc20337579342801b0 (1 reuses):
>       ../../third_party/icu/common/icudtl.dat
>     Blob ID 8b91f538b55ca960535d952c50868cfa78a5c657792f058a5d541c0e56d2dc66 (1 reuses):
>       flutter_aot_product_runner
> ```
>
> Implementation note: a custom display function is introduced instead of
> extracting a Node interface: this is because the existing Node is very
> tied into its own implementation, and doing so seemed like too much
> refactoring for fairly little gain.  If we should find ourselves needing
> more display types, then perhaps the next step would be to factor
> distinct individual types out of Node.
>
> Since I was here, I added the ability to run the test in the host
> toolchain with `fx test //tools/size_checker`.  Looks like it was not
> present by default.
>
> Bug: 63885
> Change-Id: I182dfaeb5df9220ff77fc627713f2f4eeb270139
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/449236
> Commit-Queue: Filip Filmar <fmil@google.com>
> Reviewed-by: Fady Samuel <fsamuel@google.com>
> Testability-Review: Fady Samuel <fsamuel@google.com>

TBR=fsamuel@google.com,fmil@google.com

Change-Id: I7fdd2580829c7e28747733f2753cb14d89d31bb5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 63885
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/449694
Reviewed-by: Oliver Newman <olivernewman@google.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>