commit 19b7a79f727ee6541160ec79e203fe44907a4261
author Aidan Wolter <awolter@google.com> Thu Oct 17 20:44:43 2024 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 17 20:44:43 2024 +0000
tree bee21c52078486f166ebf5e1b87dc4ea44321b67
parent 0e1408ef472401bcde73204ae34859635253e272

[assembly] Allow overrides to __append_to_ lists

The default merge strategy for developer overrides is to fully override
any key found in a dictionary. This is simple to understand but causes
extra toil for developers that want to add a new entry to a list. It
would require the developer to find the config definition, copy the
previous list into their developer overrides, then add their entry to
the list. The config definition may be in a separate repository at a
specific pinned version, therefore the previous list could be hard to
find.

This CL adds the ability to developers to indicate that they want to
append to the previous list instead of overriding it.

We cannot use periods or colons as delimiters, because this must work
with both GN and Bazel. Extra underscores are our best option.

Suggest we have this config:

{
  key: [ value1, value2, value3 ],
}

Developers can put this in their overrides to append:

{
  __append_to_key: [ value4 ],
}

And the result would be:

{
  key: [ value1, value2, value3, value4 ]
}

Change-Id: I516a15048a5ac81de6ed86e8973a84b77a1b7a74
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1137515
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Aidan Wolter <awolter@google.com>
Reviewed-by: Aaron Wood <aaronwood@google.com>
Reviewed-by: David Iserovich <diserovich@google.com>