commit | 197e35a12923e4888ccbc6f003c5ed5f0aac19fd | [log] [tgz] |
---|---|---|
author | Mitchell Kember <mkember@google.com> | Tue Oct 27 19:03:55 2020 +0000 |
committer | CQ Bot <commit-bot@chromium.org> | Tue Oct 27 19:03:55 2020 +0000 |
tree | 87520bde3d02d9290b81782beebc8c784b954e22 | |
parent | cb0c9fedb321e2ac094baa095f361f128fb03688 [diff] |
[fidl][hlcpp] Fix bug in flexible union move constructor This CL fixes a bug in HLCPP's move constructor for flexible unions. It was only copying the unknown_data_.bytes rather than the entire unknown_data_, leaving the handles field uninitialized. This manifested as a misaligned pointer crash in the union's destructor. Test: fx test fidl-hlcpp-conformance-test Fixed: 62819 Change-Id: I8c0a213310a8dc99dcf662a9be56b4aed6fb5b0e Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/443495 Commit-Queue: Mitchell Kember <mkember@google.com> Reviewed-by: Felix Zhu <fcz@google.com> Testability-Review: Felix Zhu <fcz@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.