commit f073574c70667a60df096add92067269e2cb5244
author Chase Latta <chaselatta@google.com> Sat May 21 00:22:41 2022 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat May 21 00:22:41 2022 +0000
tree 3e3ff5e0e7fd3268bcfd00bf1e3ec015b9ed38fc
parent 18e123c5a75f5060fe9d9dfa8528c1c039be7929

[dart] cleanup analysis errors

Change-Id: I57c8c7033e8d72dcfdc0978c845be2b8e70282bf
Reviewed-on: https://fuchsia-review.googlesource.com/c/experiences/+/681578
Commit-Queue: Chase Latta <chaselatta@google.com>
Reviewed-by: Charles Whitten <cwhitten@google.com>

session_shells/ermine/login/lib/src/widgets/details.dart

diff --git a/session_shells/ermine/login/lib/src/widgets/details.dart b/session_shells/ermine/login/lib/src/widgets/details.dart
index 11be1dc..00366ff 100644
--- a/session_shells/ermine/login/lib/src/widgets/details.dart
+++ b/session_shells/ermine/login/lib/src/widgets/details.dart
@@ -12,7 +12,7 @@
   final Widget? scrollableContent;
   final List<ButtonStyleButton> buttons;
 
-  Details(
+  const Details(
       {required this.title,
       required this.description,
       required this.buttons,

session_shells/ermine/shell/lib/src/states/settings_state_impl.dart

diff --git a/session_shells/ermine/shell/lib/src/states/settings_state_impl.dart b/session_shells/ermine/shell/lib/src/states/settings_state_impl.dart
index 331a262..ab1b3ca 100644
--- a/session_shells/ermine/shell/lib/src/states/settings_state_impl.dart
+++ b/session_shells/ermine/shell/lib/src/states/settings_state_impl.dart
@@ -75,7 +75,6 @@
   @override
   final Map<String, Set<String>> shortcutBindings;
 
-  @override
   DisplayDialogCallback displayDialog;
 
   @override
@@ -259,7 +258,7 @@
     required this.channelService,
     required this.volumeService,
     required this.wifiService,
-  })   : _timezones = _loadTimezones(),
+  })  : _timezones = _loadTimezones(),
         _selectedTimezone = timezoneService.timezone.asObservable() {
     dataSharingConsentService.onChanged =
         (consent) => runInAction(() => dataSharingConsentEnabled = consent);
@@ -272,8 +271,8 @@
           final addresses = interfaces
               .expand((interface) => interface.addresses)
               .toList(growable: false)
-                ..sort((addr1, addr2) =>
-                    addr1.type == InternetAddressType.IPv4 ? -1 : 0);
+            ..sort((addr1, addr2) =>
+                addr1.type == InternetAddressType.IPv4 ? -1 : 0);
 
           runInAction(() => networkAddresses
             ..clear()

session_shells/ermine/shell/lib/src/widgets/user_feedback.dart

diff --git a/session_shells/ermine/shell/lib/src/widgets/user_feedback.dart b/session_shells/ermine/shell/lib/src/widgets/user_feedback.dart
index 306f4bd..92a74ac 100644
--- a/session_shells/ermine/shell/lib/src/widgets/user_feedback.dart
+++ b/session_shells/ermine/shell/lib/src/widgets/user_feedback.dart
@@ -5,7 +5,6 @@
 import 'package:ermine/src/states/app_state.dart';
 import 'package:ermine_utils/ermine_utils.dart';
 import 'package:flutter/material.dart';
-import 'package:flutter/services.dart';
 import 'package:flutter_mobx/flutter_mobx.dart';
 import 'package:internationalization/strings.dart';
 

tests/e2e/test/ermine_terminal_test.dart

diff --git a/tests/e2e/test/ermine_terminal_test.dart b/tests/e2e/test/ermine_terminal_test.dart
index ef54e85..1c84397 100644
--- a/tests/e2e/test/ermine_terminal_test.dart
+++ b/tests/e2e/test/ermine_terminal_test.dart
@@ -196,9 +196,10 @@
       // Try to restart SL4F
       await sl4f.startServer();
       expect(await sl4f.isRunning(), isTrue);
+      //ignore: avoid_catches_without_on_clauses
     } catch (e, s) {
-      print("exception: $e");
-      print("stack trace: $s");
+      print('exception: $e');
+      print('stack trace: $s');
     }
   }, timeout: Timeout(Duration(minutes: 2)));
 }

tests/lib/ermine_driver.dart

diff --git a/tests/lib/ermine_driver.dart b/tests/lib/ermine_driver.dart
index e6f0dfe..610c57d 100644
--- a/tests/lib/ermine_driver.dart
+++ b/tests/lib/ermine_driver.dart
@@ -95,7 +95,7 @@
   Future<void> tearDown() async {
     final result = await sl4f.ssh.run('session_control restart');
     if (result.exitCode != 0) {
-      fail('failed to restart workstation session: ${result.exitCode},' +
+      fail('failed to restart workstation session: ${result.exitCode},'
           ' stderr: ${result.stderr}, stdout: ${result.stdout}');
     }
     await _driver?.close();