[dart][strict-deps] List all deps
Bug: 57840
Change-Id: I4647380494988f49fc703236f1d0f9279715b20a
Reviewed-on: https://fuchsia-review.googlesource.com/c/experiences/+/427253
Reviewed-by: Kevin Lindkvist <lindkvist@google.com>
Commit-Queue: Adam Lesinski <adamlesinski@google.com>
diff --git a/bin/simple_browser/BUILD.gn b/bin/simple_browser/BUILD.gn
index d3fefa4..52a30d9 100644
--- a/bin/simple_browser/BUILD.gn
+++ b/bin/simple_browser/BUILD.gn
@@ -14,10 +14,6 @@
main_dart = "lib/main.dart"
package_name = "simple_browser"
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
meta = [
{
path = rebase_path("meta/simple_browser.cmx")
@@ -52,17 +48,24 @@
deps = [
"//sdk/fidl/fuchsia.intl",
+ "//sdk/fidl/fuchsia.io",
"//sdk/fidl/fuchsia.ui.shortcut",
+ "//sdk/fidl/fuchsia.ui.views",
"//sdk/fidl/fuchsia.web",
"//src/experiences/bin/simple_browser_internationalization:internationalization",
"//src/experiences/session_shells/ermine/keyboard_shortcuts",
"//third_party/dart-pkg/git/flutter/packages/flutter",
+ "//third_party/dart-pkg/git/flutter/packages/flutter_localizations",
"//third_party/dart-pkg/pub/html_unescape",
"//third_party/dart-pkg/pub/http",
"//third_party/dart-pkg/pub/intl",
+ "//third_party/dart-pkg/pub/meta",
+ "//topaz/public/dart/fidl",
+ "//topaz/public/dart/fuchsia_internationalization_flutter",
"//topaz/public/dart/fuchsia_logger",
"//topaz/public/dart/fuchsia_scenic_flutter",
"//topaz/public/dart/fuchsia_services",
+ "//topaz/public/dart/zircon",
]
resources = [
@@ -89,10 +92,6 @@
"widgets/tabs_widget_test.dart",
]
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
deps = [
":simple_browser_dart_library",
"//sdk/fidl/fuchsia.web",
@@ -111,10 +110,6 @@
},
]
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [ "simple_browser_target_test.dart" ]
deps = [
diff --git a/bin/simple_browser_internationalization/BUILD.gn b/bin/simple_browser_internationalization/BUILD.gn
index e00db09..eda7bd3 100644
--- a/bin/simple_browser_internationalization/BUILD.gn
+++ b/bin/simple_browser_internationalization/BUILD.gn
@@ -15,10 +15,6 @@
# https://github.com/dart-lang/sdk/issues/38598.
disable_analysis = true
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [
"localization/messages_all.dart",
"localization/messages_ar-XB.dart",
@@ -38,5 +34,6 @@
"//third_party/dart-pkg/git/flutter/packages/flutter_localizations",
"//third_party/dart-pkg/pub/intl",
"//topaz/public/dart/fuchsia_internationalization_flutter",
+ "//topaz/public/dart/fuchsia_logger",
]
}
diff --git a/examples/hello_experiences/BUILD.gn b/examples/hello_experiences/BUILD.gn
index 70e3b3b..dd56afc 100644
--- a/examples/hello_experiences/BUILD.gn
+++ b/examples/hello_experiences/BUILD.gn
@@ -19,22 +19,14 @@
flutter_component("component") {
component_name = "hello-experiences"
manifest = "meta/hello_experiences.cmx"
- deps = [
- ":lib"
- ]
+ deps = [ ":lib" ]
}
fuchsia_package("hello-experiences") {
- deps = [
- ":component"
- ]
+ deps = [ ":component" ]
}
flutter_test("hello_experiences_unittests") {
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [ "sample_test.dart" ]
deps = [ "//third_party/dart-pkg/pub/test" ]
diff --git a/examples/localized_flutter/localized_flutter_app/BUILD.gn b/examples/localized_flutter/localized_flutter_app/BUILD.gn
index c3134dd..487d4ff 100644
--- a/examples/localized_flutter/localized_flutter_app/BUILD.gn
+++ b/examples/localized_flutter/localized_flutter_app/BUILD.gn
@@ -10,11 +10,11 @@
dart_library("lib") {
package_name = "localized_flutter_app"
sources = [
+ "localized_mod_localizations_delegate.dart",
+ "localized_mod_strings.dart",
"main.dart",
"provider.dart",
"supported_locales.dart",
- "localized_mod_localizations_delegate.dart",
- "localized_mod_strings.dart",
]
deps = [
"//src/experiences/examples/localized_flutter/localized_flutter_localization:localized-flutter-localization",
@@ -27,22 +27,14 @@
flutter_component("component") {
component_name = "localized-flutter-app"
manifest = "meta/localized_flutter_app.cmx"
- deps = [
- ":lib"
- ]
+ deps = [ ":lib" ]
}
fuchsia_package("localized-flutter-app") {
- deps = [
- ":component"
- ]
+ deps = [ ":component" ]
}
flutter_test("localized_flutter_app_unittests") {
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [ "sample_test.dart" ]
deps = [ "//third_party/dart-pkg/pub/test" ]
diff --git a/lib/quickui/BUILD.gn b/lib/quickui/BUILD.gn
index 84b66ee..6379a34 100644
--- a/lib/quickui/BUILD.gn
+++ b/lib/quickui/BUILD.gn
@@ -17,9 +17,6 @@
}
dart_test("quickui_unittests") {
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
sources = [
"quickui_test.dart",
"uistream_test.dart",
@@ -27,6 +24,7 @@
deps = [
":quickui",
+ "//sdk/fidl/fuchsia.ui.remotewidgets",
"//third_party/dart-pkg/pub/mockito",
"//third_party/dart-pkg/pub/test",
]
diff --git a/session_shells/ermine/internationalization/BUILD.gn b/session_shells/ermine/internationalization/BUILD.gn
index e00db09..eda7bd3 100644
--- a/session_shells/ermine/internationalization/BUILD.gn
+++ b/session_shells/ermine/internationalization/BUILD.gn
@@ -15,10 +15,6 @@
# https://github.com/dart-lang/sdk/issues/38598.
disable_analysis = true
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [
"localization/messages_all.dart",
"localization/messages_ar-XB.dart",
@@ -38,5 +34,6 @@
"//third_party/dart-pkg/git/flutter/packages/flutter_localizations",
"//third_party/dart-pkg/pub/intl",
"//topaz/public/dart/fuchsia_internationalization_flutter",
+ "//topaz/public/dart/fuchsia_logger",
]
}
diff --git a/session_shells/ermine/settings/BUILD.gn b/session_shells/ermine/settings/BUILD.gn
index 3daa7c9..62ca357 100644
--- a/session_shells/ermine/settings/BUILD.gn
+++ b/session_shells/ermine/settings/BUILD.gn
@@ -8,10 +8,6 @@
dart_library("settings") {
package_name = "settings"
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [
"settings.dart",
"src/battery.dart",
@@ -31,9 +27,12 @@
"//sdk/fidl/fuchsia.power",
"//sdk/fidl/fuchsia.settings",
"//sdk/fidl/fuchsia.ui.brightness",
+ "//sdk/fidl/fuchsia.ui.remotewidgets",
"//src/experiences/lib/quickui",
"//src/experiences/session_shells/ermine/internationalization",
"//third_party/dart-pkg/git/flutter/packages/flutter",
+ "//third_party/dart-pkg/pub/async",
+ "//third_party/dart-pkg/pub/intl",
"//topaz/public/dart/fuchsia_services",
]
}
@@ -49,13 +48,20 @@
"volume_test.dart",
]
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
deps = [
":settings",
+ "//sdk/fidl/fuchsia.bluetooth.control",
+ "//sdk/fidl/fuchsia.intl",
+ "//sdk/fidl/fuchsia.media",
+ "//sdk/fidl/fuchsia.memory",
+ "//sdk/fidl/fuchsia.power",
+ "//sdk/fidl/fuchsia.settings",
+ "//sdk/fidl/fuchsia.ui.brightness",
+ "//sdk/fidl/fuchsia.ui.remotewidgets",
+ "//src/experiences/lib/quickui",
+ "//src/experiences/session_shells/ermine/internationalization",
"//third_party/dart-pkg/git/flutter/packages/flutter_test",
"//third_party/dart-pkg/pub/mockito",
+ "//topaz/public/dart/fidl",
]
}
diff --git a/session_shells/ermine/shell/BUILD.gn b/session_shells/ermine/shell/BUILD.gn
index aaffa41..852cff0 100644
--- a/session_shells/ermine/shell/BUILD.gn
+++ b/session_shells/ermine/shell/BUILD.gn
@@ -22,10 +22,6 @@
flutter_app("ermine") {
main_dart = "lib/main.dart"
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
fuchsia_package_name = "ermine"
package_name = "ermine"
@@ -93,9 +89,11 @@
"//sdk/fidl/fuchsia.device.manager",
"//sdk/fidl/fuchsia.feedback",
"//sdk/fidl/fuchsia.intl",
+ "//sdk/fidl/fuchsia.mem",
"//sdk/fidl/fuchsia.memory",
"//sdk/fidl/fuchsia.power",
"//sdk/fidl/fuchsia.session",
+ "//sdk/fidl/fuchsia.sys",
"//sdk/fidl/fuchsia.ui.app",
"//sdk/fidl/fuchsia.ui.focus",
"//sdk/fidl/fuchsia.ui.input",
@@ -115,11 +113,16 @@
"//third_party/dart-pkg/pub/async",
"//third_party/dart-pkg/pub/flutter_svg",
"//third_party/dart-pkg/pub/intl",
+ "//third_party/dart-pkg/pub/meta",
"//third_party/dart-pkg/pub/uuid",
+ "//third_party/dart-pkg/pub/vector_math",
+ "//topaz/public/dart/fidl",
"//topaz/public/dart/fuchsia_inspect",
+ "//topaz/public/dart/fuchsia_internationalization_flutter",
"//topaz/public/dart/fuchsia_logger",
"//topaz/public/dart/fuchsia_scenic_flutter",
"//topaz/public/dart/fuchsia_services",
+ "//topaz/public/dart/zircon",
]
non_dart_deps = [ ":time_zone_list" ]
@@ -183,15 +186,25 @@
"topbar_model_test.dart",
]
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
deps = [
":ermine_dart_library",
+ "//sdk/fidl/fuchsia.device.manager",
+ "//sdk/fidl/fuchsia.feedback",
+ "//sdk/fidl/fuchsia.ui.focus",
+ "//sdk/fidl/fuchsia.ui.input",
+ "//sdk/fidl/fuchsia.ui.views",
+ "//src/experiences/lib/quickui",
+ "//src/experiences/session_shells/ermine/keyboard_shortcuts",
+ "//third_party/dart-pkg/git/flutter/packages/flutter",
"//third_party/dart-pkg/git/flutter/packages/flutter_test",
+ "//third_party/dart-pkg/pub/intl",
"//third_party/dart-pkg/pub/mockito",
"//third_party/dart-pkg/pub/test",
+ "//topaz/public/dart/fidl",
+ "//topaz/public/dart/fuchsia_internationalization_flutter",
+ "//topaz/public/dart/fuchsia_logger",
+ "//topaz/public/dart/fuchsia_scenic_flutter",
+ "//topaz/public/dart/zircon",
]
}
diff --git a/session_shells/ermine/tiler/BUILD.gn b/session_shells/ermine/tiler/BUILD.gn
index 959d1b1..8109f68 100644
--- a/session_shells/ermine/tiler/BUILD.gn
+++ b/session_shells/ermine/tiler/BUILD.gn
@@ -26,10 +26,7 @@
deps = [
":tiler",
+ "//third_party/dart-pkg/git/flutter/packages/flutter",
"//third_party/dart-pkg/git/flutter/packages/flutter_test",
]
-
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
}
diff --git a/settings/lib/settings/BUILD.gn b/settings/lib/settings/BUILD.gn
index c974c61..9f7aba9 100644
--- a/settings/lib/settings/BUILD.gn
+++ b/settings/lib/settings/BUILD.gn
@@ -7,10 +7,6 @@
dart_library("settings") {
package_name = "lib.settings"
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [
"debug.dart",
"device_info.dart",
@@ -22,6 +18,7 @@
"//sdk/fidl/fuchsia.devicesettings",
"//src/experiences/settings/lib/widgets",
"//third_party/dart-pkg/git/flutter/packages/flutter",
+ "//third_party/dart-pkg/pub/meta",
"//topaz/public/dart/fuchsia_logger",
"//topaz/public/dart/fuchsia_services",
]
diff --git a/tests/e2e/BUILD.gn b/tests/e2e/BUILD.gn
index 7543ec1..76605cb 100644
--- a/tests/e2e/BUILD.gn
+++ b/tests/e2e/BUILD.gn
@@ -6,10 +6,6 @@
import("//build/testing/environments.gni")
dart_test("experiences_ermine_session_shell_e2e_test") {
- # TODO(fxb/57840): This package has transitive dependencies.
- # Please explicitly define its transitive dependencies as direct dependencies then remove this exemption
- disable_strict_deps_check = true
-
sources = [
"ermine_driver.dart",
@@ -24,6 +20,7 @@
deps = [
"//sdk/testing/sl4f/client",
"//sdk/testing/sl4f/flutter_driver_sl4f",
+ "//third_party/dart-pkg/git/flutter/packages/flutter_driver",
"//third_party/dart-pkg/pub/test",
]
