commit 96f1bdd2b6cfc0329e10e65719a6d477fcb5f9f5
author Sanjay Chouksey <sanjayc@google.com> Thu Mar 26 22:35:28 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Thu Mar 26 22:35:28 2020 +0000
tree a3408842044847bc5f3a8ddcc41f87e889c17e7c
parent 2e3162b4a9016ed7f7c13fd1f69e4fee3d7ee2ce

[ermine] Handle invalid component suggestions

This change handles the exception thrown by component index when
it is queried for text containing invalid characters.

Bug: 47483
Change-Id: I1e0bdcca881b1f8bd78f48c795231825acbe2339

session_shells/ermine/shell/lib/src/utils/suggestions.dart

diff --git a/session_shells/ermine/shell/lib/src/utils/suggestions.dart b/session_shells/ermine/shell/lib/src/utils/suggestions.dart
index 428d3f4..0250f2f 100644
--- a/session_shells/ermine/shell/lib/src/utils/suggestions.dart
+++ b/session_shells/ermine/shell/lib/src/utils/suggestions.dart
@@ -5,6 +5,7 @@
 import 'package:fidl_fuchsia_sys_index/fidl_async.dart';
 import 'package:fidl_fuchsia_sys/fidl_async.dart';
 import 'package:flutter/foundation.dart';
+import 'package:fuchsia_logger/logger.dart';
 import 'package:fuchsia_services/services.dart';
 import 'package:meta/meta.dart';
 
@@ -74,16 +75,20 @@
       return newSuggestions;
     }
 
-    final results = await _componentIndex.fuzzySearch(query);
-    newSuggestions.addAll(results.map((url) {
-      final re = RegExp(r'fuchsia-pkg://fuchsia.com/(.+)#meta/.+');
-      final name = re.firstMatch(url)?.group(1);
-      return Suggestion(
-        id: '$url:${DateTime.now().millisecondsSinceEpoch}',
-        url: url,
-        title: name,
-      );
-    }));
+    try {
+      final results = await _componentIndex.fuzzySearch(query);
+      newSuggestions.addAll(results.map((url) {
+        final re = RegExp(r'fuchsia-pkg://fuchsia.com/(.+)#meta/.+');
+        final name = re.firstMatch(url)?.group(1);
+        return Suggestion(
+          id: '$url:${DateTime.now().millisecondsSinceEpoch}',
+          url: url,
+          title: name,
+        );
+      }));
+    } on Exception catch (e) {
+      log.info('Component Index error: $e');
+    }
 
     return newSuggestions.take(maxSuggestions);
   }