commit 7bf26e47c646de326f941f9572b90c34ab9f7303
author Sanjay Chouksey <sanjayc@google.com> Thu Jul 16 01:35:41 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Thu Jul 16 01:35:41 2020 +0000
tree 111e4d3cee36905f74a73e169bd3b5bdb76aeef8
parent 18b74073fa8019b6c6300f6758ec1a348c2de237

[benchmarks] Fix exception in scroll_flutter benchmarks app

The app needed a Directionality widget as the root widget. Normally,
this is provided by MaterialApp widget.

Bug: 55386
Change-Id: Ib2dbe461986f78ad73ae6f4aceb01a542506eef2
Reviewed-on: https://fuchsia-review.googlesource.com/c/experiences/+/407119
Reviewed-by: David Reveman <reveman@google.com>
Testability-Review: David Reveman <reveman@google.com>
Commit-Queue: Sanjay Chouksey <sanjayc@google.com>

benchmarks/bin/scroll_flutter/lib/main.dart

diff --git a/benchmarks/bin/scroll_flutter/lib/main.dart b/benchmarks/bin/scroll_flutter/lib/main.dart
index d4df679..61f6879 100644
--- a/benchmarks/bin/scroll_flutter/lib/main.dart
+++ b/benchmarks/bin/scroll_flutter/lib/main.dart
@@ -144,26 +144,29 @@
 
   @override
   Widget build(BuildContext context) {
-    return ConstrainedBox(
-      constraints: BoxConstraints.expand(),
-      child: Container(
-        color: Colors.white,
-        child: ListView(
-          controller: _controller,
-          children: <Widget>[
-            Container(height: 8192.0),
-            Center(
-              child: Text(
-                'Scroll Me!',
-                style: TextStyle(
-                  color: Colors.black,
-                  fontWeight: FontWeight.bold,
-                  fontSize: 32,
+    return Directionality(
+      textDirection: ui.TextDirection.ltr,
+      child: ConstrainedBox(
+        constraints: BoxConstraints.expand(),
+        child: Container(
+          color: Colors.white,
+          child: ListView(
+            controller: _controller,
+            children: <Widget>[
+              Container(height: 8192.0),
+              Center(
+                child: Text(
+                  'Scroll Me!',
+                  style: TextStyle(
+                    color: Colors.black,
+                    fontWeight: FontWeight.bold,
+                    fontSize: 32,
+                  ),
                 ),
               ),
-            ),
-            Container(height: 8192.0),
-          ],
+              Container(height: 8192.0),
+            ],
+          ),
         ),
       ),
     );