commit 406bbf867c62a70e4f7efdcb8efca67c086abb4a
author Braden Kell <bradenkell@google.com> Wed Jul 28 18:46:21 2021 +0000
committer CQ Bot <commit-bot@chromium.org> Wed Jul 28 18:46:21 2021 +0000
tree e017d1291a9df94c70b56b7e5cd1420a2bcbc03c
parent 5ef1b8f84d87d61e6e0d2c38ff0322a2a995e424

[sdio] Add metrics and reports to include devices with zero errors

The previous occurrence metrics don't include devices with zero errors.
We would like to include these devices in order to determine how much of
the fleet is affected.

Bug: 68438
Test: CQ
Change-Id: Ia41128d7cedafe4f914e237fa26cf524c9805231
Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt-registry/+/561121
Reviewed-by: Cameron Dale <camrdale@google.com>
Privacy-Approval: Cameron Dale <camrdale@google.com>
Commit-Queue: Braden Kell <bradenkell@google.com>

fuchsia/sdmmc/metrics.yaml

diff --git a/fuchsia/sdmmc/metrics.yaml b/fuchsia/sdmmc/metrics.yaml
index f7f9998..3de9a01 100644
--- a/fuchsia/sdmmc/metrics.yaml
+++ b/fuchsia/sdmmc/metrics.yaml
@@ -9,7 +9,7 @@
 metric_definitions:
 
 ################################################################################
-# Next Metric ID: 3
+# Next Metric ID: 5
 ################################################################################
 
 ################################################################################
@@ -71,3 +71,63 @@
   meta_data:
     max_release_stage: GA
     expiration_date: "2022/07/20"
+
+################################################################################
+# sdio_tx_error_integer
+#
+# Total number of SDIO TX errors, logged by the SDIO core driver via Lapis.
+################################################################################
+- id: 3
+  metric_name: sdio_tx_error_integer
+  metric_units_other: "errors"
+  metric_type: INTEGER
+  metric_semantics: [METRIC_SEMANTICS_UNSPECIFIED]
+  reports:
+    - report_name: histogram
+      id: 1
+      report_type: HOURLY_VALUE_HISTOGRAMS
+      privacy_level: NO_ADDED_PRIVACY
+      local_aggregation_procedure: MAX_PROCEDURE
+      int_buckets: *sdio_error_buckets
+      system_profile_field: [BOARD_NAME, PRODUCT_NAME, SYSTEM_VERSION, CHANNEL]
+    - report_name: histogram_daily
+      id: 2
+      report_type: UNIQUE_DEVICE_HISTOGRAMS
+      local_aggregation_period: WINDOW_1_DAY
+      privacy_level: NO_ADDED_PRIVACY
+      local_aggregation_procedure: MAX_PROCEDURE
+      int_buckets: *sdio_error_buckets
+      system_profile_field: [BOARD_NAME, PRODUCT_NAME, SYSTEM_VERSION, CHANNEL]
+  meta_data:
+    max_release_stage: GA
+    expiration_date: "2022/07/27"
+
+################################################################################
+# sdio_rx_error_integer
+#
+# Total number of SDIO RX errors, logged by the SDIO core driver via Lapis.
+################################################################################
+- id: 4
+  metric_name: sdio_rx_error_integer
+  metric_units_other: "errors"
+  metric_type: INTEGER
+  metric_semantics: [METRIC_SEMANTICS_UNSPECIFIED]
+  reports:
+    - report_name: INTEGER
+      id: 1
+      report_type: HOURLY_VALUE_HISTOGRAMS
+      privacy_level: NO_ADDED_PRIVACY
+      local_aggregation_procedure: MAX_PROCEDURE
+      int_buckets: *sdio_error_buckets
+      system_profile_field: [BOARD_NAME, PRODUCT_NAME, SYSTEM_VERSION, CHANNEL]
+    - report_name: histogram_daily
+      id: 2
+      report_type: UNIQUE_DEVICE_HISTOGRAMS
+      local_aggregation_period: WINDOW_1_DAY
+      privacy_level: NO_ADDED_PRIVACY
+      local_aggregation_procedure: MAX_PROCEDURE
+      int_buckets: *sdio_error_buckets
+      system_profile_field: [BOARD_NAME, PRODUCT_NAME, SYSTEM_VERSION, CHANNEL]
+  meta_data:
+    max_release_stage: GA
+    expiration_date: "2022/07/27"