WIP(crashpad): -Wno-missing-field-initializers for minidump tests
Change-Id: I6730d918cc056f6d96cca601de20c2abc841c2b1
diff --git a/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn b/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn
index 8368bd1..cc42823 100644
--- a/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn
+++ b/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn
@@ -100,6 +100,20 @@
]
}
+# GN orders target flags before config flags. These flags need to be after
+# the -Wall added by the default config, so they can't live on the executable
+# target (whose flags appear before the default config).
+config("minidump_test_config") {
+ visibility = [ "./*" ]
+ # Allows initializers like "MINIDUMP_STRING x = {0}" which don't provide
+ # values for all fields. Normally we would use "= {}", but MSVC doesn't like
+ # it, possibly because of the zero-length array in MINIDUMP_STRING.
+ # TODO: if(fuchsia)
+ cflags = [
+ "-Wno-missing-field-initializers"
+ ]
+}
+
executable("minidump_test") {
testonly = true
@@ -137,4 +151,6 @@
"minidump_user_stream_writer_test.cc",
"minidump_writable_test.cc",
]
+
+ configs += [ ":minidump_test_config" ]
}
