commit 9abb43e65c464e4ef80b6d75cb1e8a7ec2d14b36
author Sam Lantinga <slouken@libsdl.org> Wed Oct 19 20:39:12 2016 -0700
committer Sam Lantinga <slouken@libsdl.org> Wed Oct 19 20:39:12 2016 -0700
tree 94263dcd169ea41f30f68a535d81a0e2736eefc1
parent b18133c80882377ae58546f4fcd8071b4e565beb

Fixed crash on Mac OS X 10.10 and earlier

src/video/cocoa/SDL_cocoakeyboard.m

diff --git a/src/video/cocoa/SDL_cocoakeyboard.m b/src/video/cocoa/SDL_cocoakeyboard.m
index 91267e5..8b2ed91 100644
--- a/src/video/cocoa/SDL_cocoakeyboard.m
+++ b/src/video/cocoa/SDL_cocoakeyboard.m
@@ -195,6 +195,11 @@
 static void
 HIDCallback(void *context, IOReturn result, void *sender, IOHIDValueRef value)
 {
+    if (context != s_hidManager) {
+        /* An old callback, ignore it (related to bug 2157 below) */
+        return;
+    }
+
     IOHIDElementRef elem = IOHIDValueGetElement(value);
     if (IOHIDElementGetUsagePage(elem) != kHIDPage_KeyboardOrKeypad
         || IOHIDElementGetUsage(elem) != kHIDUsage_KeyboardCapsLock) {
@@ -232,13 +237,14 @@
     if (!s_hidManager) {
         return;
     }
-    IOHIDManagerUnscheduleFromRunLoop(s_hidManager, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
-    IOHIDManagerRegisterInputValueCallback(s_hidManager, NULL, NULL);
-    IOHIDManagerClose(s_hidManager, 0);
 
 #if 0 /* Releasing here causes a crash on Mac OS X 10.10 and earlier,
        * so just leak it for now. See bug 2157 for details.
        */
+    IOHIDManagerUnscheduleFromRunLoop(s_hidManager, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+    IOHIDManagerRegisterInputValueCallback(s_hidManager, NULL, NULL);
+    IOHIDManagerClose(s_hidManager, 0);
+
     CFRelease(s_hidManager);
 #endif
     s_hidManager = NULL;
@@ -267,7 +273,7 @@
         goto fail;
     }
     IOHIDManagerSetDeviceMatchingMultiple(s_hidManager, matches);
-    IOHIDManagerRegisterInputValueCallback(s_hidManager, HIDCallback, NULL);
+    IOHIDManagerRegisterInputValueCallback(s_hidManager, HIDCallback, s_hidManager);
     IOHIDManagerScheduleWithRunLoop(s_hidManager, CFRunLoopGetMain(), kCFRunLoopDefaultMode);
     if (IOHIDManagerOpen(s_hidManager, kIOHIDOptionsTypeNone) == kIOReturnSuccess) {
         goto cleanup;