tree 6bd23a9ddb974d67282fdad2dd2507a1f88f6bec
parent f3a042ed056fc49a59a3798908dfe82327c59c9f
author Abdulla Kamar <abdulla@google.com> 1544388044 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1544389169 +0000

Revert "[fdio] do not accept sockets with a full fd table"

This reverts commit bcc6f70f8d4d666f3a6c2273d5a611b750dbb82a.

Reason for revert: This is causing NetStreamTest.BlockingAcceptWrite to timeout.

Original change's description:
> [fdio] do not accept sockets with a full fd table
> 
> If the fd table is full, pulling sockets from the control channel results in
> consuming the incoming connection, but being unable to actually service it -
> we then immediately close (which then ends up in linger). Other processes
> would then not be able to pull these sockets (in a load balance scenario),
> and netstack also potentially loses the ability to apply policy from having a
> full listen queue. Instead, try to allocate an fd up front, and only if found
> accept the socket from the control channel. This is more conformant with
> common accept behaviors.
> 
> Test: install a package with 5500 blobs with a package server routed via a remote port forward over ssh. Observe successful install rather than failure.
> Bug: PKG-371 #comment fdio: do not accept sockets with a full fd table
> Change-Id: Idb5513ada590b0d8da2f5cd68b4d734765e438d4

TBR=jamesr@google.com,mcgrathr@google.com,raggi@google.com,marshallk@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: PKG-371 #comment fdio: do not accept sockets with a full fd table
Change-Id: I31716bafa4cee2116cca16541d4348025c571e56